Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: add missing case for list-keys #4245

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jun 29, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Cherry-picked hotfix for #4234

CRAFT-1804

@lengau lengau marked this pull request as ready for review June 29, 2023 21:37
@lengau lengau requested a review from sergiusens June 29, 2023 21:37
@lengau
Copy link
Contributor Author

lengau commented Jun 29, 2023

Pyright is probably going to fail; that's fixed by #4243

@lengau lengau changed the title 7.5 list keys store: add missing case for list-keys Jun 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #4245 (b50be7d) into hotfix/7.5 (b3dee09) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.5    #4245   +/-   ##
===========================================
  Coverage       94.85%   94.85%           
===========================================
  Files             648      649    +1     
  Lines           54355    54379   +24     
===========================================
+ Hits            51556    51580   +24     
  Misses           2799     2799           
Impacted Files Coverage Δ
tests/legacy/unit/commands/test_list_keys.py 100.00% <ø> (ø)
snapcraft_legacy/_store.py 77.77% <100.00%> (+0.21%) ⬆️
tests/legacy/unit/store/test_keys.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 1c44a58 into canonical:hotfix/7.5 Jun 30, 2023
10 of 12 checks passed
@lengau lengau deleted the 7.5-list-keys branch June 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants