Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/devicestate, o/snapstate: move firstboot configure task after essential snap installs #13127

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ernestl
Copy link
Collaborator

@ernestl ernestl commented Aug 28, 2023

This PR builds on #13117 and primarily on #13097.

Implements draft spec parts:

  • Trivial seed install task order
  • Seed install task order
  • Preseed install task order

Outstanding: testing, spread and unit tests

@ernestl ernestl added the Skip spread Indicate that spread job should not run label Aug 30, 2023
@ernestl ernestl closed this Aug 30, 2023
@ernestl ernestl reopened this Aug 30, 2023
@ernestl ernestl force-pushed the SNAPDENG-7297_Improve_Seeding_Snap_Task_Order_For_Services_Configure_Deps branch from 29f142c to 83e9bb7 Compare September 4, 2023 10:28
@ernestl ernestl force-pushed the SNAPDENG-7297_Improve_Seeding_Snap_Task_Order_For_Services_Configure_Deps branch from 7a2c102 to ce324a5 Compare September 7, 2023 14:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #13127 (463ace0) into master (7c17cf2) will increase coverage by 0.03%.
Report is 50 commits behind head on master.
The diff coverage is 82.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #13127      +/-   ##
==========================================
+ Coverage   78.80%   78.83%   +0.03%     
==========================================
  Files        1011     1013       +2     
  Lines      125739   126150     +411     
==========================================
+ Hits        99085    99451     +366     
- Misses      20442    20480      +38     
- Partials     6212     6219       +7     
Flag Coverage Δ
unittests 78.83% <82.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
overlord/snapstate/snapstate.go 84.20% <80.48%> (-0.18%) ⬇️
overlord/devicestate/firstboot.go 85.57% <81.67%> (-3.61%) ⬇️
overlord/snapstate/flags.go 100.00% <100.00%> (ø)
overlord/state/task.go 95.94% <100.00%> (+0.17%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ernestl ernestl removed the Skip spread Indicate that spread job should not run label Sep 7, 2023
@ernestl ernestl closed this Sep 7, 2023
@ernestl ernestl reopened this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants