Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/devicestate, o/snapstate: improve firstboot task order #15015

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ernestl
Copy link
Collaborator

@ernestl ernestl commented Feb 3, 2025

Make corrections to firstboot install task order according to spec SD154 | Firstboot install task order

This task draws inspiration from earlier, dated work to achieve the same: #13127

enable firstboot to request configuration using gadget defaults instead of injecting the task itself

  • Adapting install code to generate configuration task, using gadget defaults, for essential snaps: core, gadget and kernel to avoid injecting configure tasks from the first boot install code. The exception remains when core snap is not installed, a configuration need to be injected.
  • Introduced configure edge, that is required to provide reference for reorganizing the install taskset within the firstboot code.
  • None of the tests are affected at this point, but little more simplification is required once the firstboot code changes and stop injecting configure hooks for essential snaps.

JIRA: https://warthogs.atlassian.net/browse/SNAPDENG-7297

@ernestl ernestl added the Run nested The PR also runs tests inluded in nested suite label Feb 3, 2025
@ernestl ernestl closed this Feb 3, 2025
@ernestl ernestl reopened this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Sun Feb 9 22:26:26 UTC 2025

Spread tests skipped

… (gadget defaults) via install instead of injecting the tasks (partial, needs adjustments after firstboot changes)
@ernestl ernestl force-pushed the SNAPDENG-7297_Fix_Firstboot_Behavior branch from 55017b1 to 87bf39e Compare February 7, 2025 23:11
@ernestl ernestl added Skip spread Indicate that spread job should not run and removed Run nested The PR also runs tests inluded in nested suite labels Feb 7, 2025
@ernestl ernestl closed this Feb 7, 2025
@ernestl ernestl reopened this Feb 7, 2025
@ernestl ernestl changed the title Improve firstboot task order o/devicestate, o/snapstate: improve firstboot task order Feb 8, 2025
@ernestl ernestl force-pushed the SNAPDENG-7297_Fix_Firstboot_Behavior branch from 87bf39e to 3b86682 Compare February 9, 2025 08:34
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 67.56757% with 108 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@81fd929). Learn more about missing BASE report.
Report is 181 commits behind head on master.

Files with missing lines Patch % Lines
...lord/devicestate/devicestatetest/task_run_order.go 0.00% 85 Missing ⚠️
overlord/devicestate/firstboot.go 91.48% 12 Missing and 4 partials ⚠️
overlord/snapstate/snapstate.go 88.09% 4 Missing and 1 partial ⚠️
overlord/snapstate/target.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15015   +/-   ##
=========================================
  Coverage          ?   78.09%           
=========================================
  Files             ?     1171           
  Lines             ?   157042           
  Branches          ?        0           
=========================================
  Hits              ?   122637           
  Misses            ?    26795           
  Partials          ?     7610           
Flag Coverage Δ
unittests 78.09% <67.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants