Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.66 #14566

Merged
merged 6 commits into from
Oct 4, 2024
Merged

release: 2.66 #14566

merged 6 commits into from
Oct 4, 2024

Conversation

@ernestl ernestl added this to the 2.66 milestone Oct 2, 2024
@ernestl ernestl marked this pull request as draft October 2, 2024 08:48
@ernestl ernestl added the Run nested The PR also runs tests inluded in nested suite label Oct 2, 2024
@ernestl ernestl closed this Oct 2, 2024
@ernestl ernestl reopened this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/2.66@0d7c868). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/2.66   #14566   +/-   ##
===============================================
  Coverage                ?   78.87%           
===============================================
  Files                   ?     1083           
  Lines                   ?   146105           
  Branches                ?        0           
===============================================
  Hits                    ?   115236           
  Misses                  ?    23673           
  Partials                ?     7196           
Flag Coverage Δ
unittests 78.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrewphelpsj and others added 2 commits October 3, 2024 01:16
This comes up when snap-update-ns called from snapd attempts to mount on
files labeled with var_t, such as /var/cache/swcatalog.

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32055

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@ernestl ernestl force-pushed the prepare-release-2.66 branch 3 times, most recently from be105cc to 5fad13c Compare October 3, 2024 08:57
@ernestl ernestl added the Needs Samuele review Needs a review from Samuele before it can land label Oct 3, 2024
@ernestl ernestl marked this pull request as ready for review October 3, 2024 09:11
@ernestl ernestl changed the base branch from master to release/2.66 October 3, 2024 09:11
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, one question about docs

NEWS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggested some modifications to my previous summaries

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! small comments

NEWS.md Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, tiny nitpick

NEWS.md Outdated Show resolved Hide resolved
@ernestl ernestl force-pushed the prepare-release-2.66 branch 2 times, most recently from dc910e2 to e82f1f2 Compare October 3, 2024 22:12
Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

alfonsosanchezbeato and others added 2 commits October 4, 2024 14:17
* many: introduce the StandardComponent type

StandardComponent is the type of vanilla components that do not have
any special behavior from the snapd perspective and that are simply
mounted and made available to the snap. Add it and change most of the
tests so the new type is used.

* tests/main/component: make component type in component and snap the same (standard)

---------

Co-authored-by: ernestl <ernest.lotter@canonical.com>
@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Oct 4, 2024
@ernestl
Copy link
Collaborator Author

ernestl commented Oct 4, 2024

Failures:

nested-ubuntu-24.04 | <- UC team advised this is known and should not hold back release.

Failed tasks: 5

  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-kernel-failover:crash
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-kernel-reseal
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-early-config
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-initramfs-time-moves-forward
  • google-nested:ubuntu-24.04-64:tests/nested/manual/remodel-min-size
    2024-10-04 07:39:50 Failed task prepare: 1
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel

@ernestl ernestl merged commit 0b34f63 into canonical:release/2.66 Oct 4, 2024
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation Needs Samuele review Needs a review from Samuele before it can land Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants