-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 2.66 #14566
release: 2.66 #14566
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.66 #14566 +/- ##
===============================================
Coverage ? 78.87%
===============================================
Files ? 1083
Lines ? 146105
Branches ? 0
===============================================
Hits ? 115236
Misses ? 23673
Partials ? 7196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comes up when snap-update-ns called from snapd attempts to mount on files labeled with var_t, such as /var/cache/swcatalog. Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32055 Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
be105cc
to
5fad13c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, one question about docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Suggested some modifications to my previous summaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! small comments
5fad13c
to
53c9fd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, tiny nitpick
…s also present on arm systems (canonical#14572)
…PU in opengl interface (canonical#14536) undefined
dc910e2
to
e82f1f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
* many: introduce the StandardComponent type StandardComponent is the type of vanilla components that do not have any special behavior from the snapd perspective and that are simply mounted and made available to the snap. Add it and change most of the tests so the new type is used. * tests/main/component: make component type in component and snap the same (standard) --------- Co-authored-by: ernestl <ernest.lotter@canonical.com>
e82f1f2
to
dc39ca8
Compare
Failures: nested-ubuntu-24.04 | <- UC team advised this is known and should not hold back release. Failed tasks: 5
|
Generated changelogs with:
DEBEMAIL="Ernest Lotter ernest.lotter@canonical.com" release-tools/changelog.py 2.66 2083490 NEWS.md
Cherry-picked:
SRU bug: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/2083490
JIRA: https://warthogs.atlassian.net/browse/SNAPDENG-32812
Requires rebase merge