Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/selinux: allow mounting on var_t #14567

Merged

Conversation

zyga
Copy link
Contributor

@zyga zyga commented Oct 2, 2024

This comes up when snap-update-ns called from snapd attempts to mount on files labeled with var_t, such as /var/cache/swcatalog.

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32055

This comes up when snap-update-ns called from snapd attempts to mount on
files labeled with var_t, such as /var/cache/swcatalog.

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32055

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@zyga zyga added the Simple 😃 A small PR which can be reviewed quickly label Oct 2, 2024
Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bboozzoo bboozzoo added this to the 2.66 milestone Oct 2, 2024
@bboozzoo
Copy link
Contributor

bboozzoo commented Oct 2, 2024

Cherry pick for 2.66 or we can distro patch it when pushing a package update.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (ac897ee) to head (61202c5).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14567      +/-   ##
==========================================
+ Coverage   78.85%   78.87%   +0.01%     
==========================================
  Files        1079     1083       +4     
  Lines      145615   146105     +490     
==========================================
+ Hits       114828   115237     +409     
- Misses      23601    23673      +72     
- Partials     7186     7195       +9     
Flag Coverage Δ
unittests 78.87% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Meulengracht Meulengracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@ernestl ernestl merged commit 0193451 into canonical:master Oct 2, 2024
50 of 58 checks passed
ernestl pushed a commit to ernestl/snapd that referenced this pull request Oct 2, 2024
This comes up when snap-update-ns called from snapd attempts to mount on
files labeled with var_t, such as /var/cache/swcatalog.

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32055

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@ernestl ernestl mentioned this pull request Oct 2, 2024
ernestl pushed a commit that referenced this pull request Oct 4, 2024
This comes up when snap-update-ns called from snapd attempts to mount on
files labeled with var_t, such as /var/cache/swcatalog.

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32055

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants