tests: removing uc16 executions #14575
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14575 +/- ##
==========================================
+ Coverage 78.95% 79.02% +0.07%
==========================================
Files 1084 1087 +3
Lines 146638 147628 +990
==========================================
+ Hits 115773 116670 +897
- Misses 23667 23729 +62
- Partials 7198 7229 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -7,8 +7,6 @@ details: | | |||
| the new kernel snap. Finally check it is possible to remodel | |||
| back to the initial model. | |||
|
|
|||
| # FIXME: add core18 test as well | |||
| # TODO:UC20: enable for UC20 | |||
| systems: [ubuntu-core-16-64] | |||
There was a problem hiding this comment.
Why are we removing the TODO but not changing the systems?
There was a problem hiding this comment.
This is because we are testing different kernel remodeling in nested tests, and this one cannot be updated to work in uc20+ without a big refactor.
There was a problem hiding this comment.
can we rename the test to specifically indicate this one is for uc16 and not generic. The test name should probably be uc16-remodel-kernel and not remodel-kernel
There was a problem hiding this comment.
Otherwise it will give a false sense of security when looking at the test overview, we want to be explicit we are not testing this for other systems, and that we in fact need a new test for this
tests/core/iio/task.yaml
Outdated
| @@ -9,7 +9,7 @@ details: | | |||
| that, after a snap declared a iio plug is installed and connected, it can | |||
| access the node and read/write its content. | |||
|
|
|||
| systems: [ubuntu-core-16-64] | |||
| systems: [ubuntu-core-*-64] | |||
There was a problem hiding this comment.
This test seems to be failing on all the other UC systems - this was due to IIO missing in snapd right?
There was a problem hiding this comment.
right, I see this error:
error: snap "snapd" has no slot named "iio0"
@Meulengracht @alfonsosanchezbeato, What do you suggest? Should we remove the test? should we add that interface to snapd?
There was a problem hiding this comment.
If it was intentional the interface does not exist in the snapd snap, but exists on the core snap, then this must exist just as an UC16 test, and that means we should remove it from master. As long as this runs on the branch of snapd for UC16, then its good enough.
If the interface is missing from snapd (i don't see this likely, why would it be?), then we need to keep this test and fix that
This task removes tests executions for uc16 but the support remains because we need to test core snap for security releases. Other changes are included to move some tests from uc16 to uc18.
remodel-kernel to uc16-remodel-kernel
sergiocazzolato
force-pushed
the
tests-remove-uc16-support
branch
from
2d83d05
to
3d9599e
Compare
* master: (44 commits) wrappers: do not reload activation units (canonical#14724) gadget/install: support for no{exec,dev,suid} mount flags interfaces/builtin/mount_control: add support for nfs mounts (canonical#14694) tests: use gojq - part 1 (canonical#14686) interfaces/desktop-legacy: allow DBus access to com.canonical.dbusmenu interfaces/builtin/fwupd.go: allow access to nvmem for thunderbolt plugin tests: removing uc16 executions (canonical#14575) tests: Added arm github runner to build snapd (canonical#14504) tests: no need to run spread when there are not tests matching the filter (canonical#14728) tests/lib/tools/store-state: exit on errors, update relevant tests (canonical#14725) tests: udpate the github workflow to run tests suggested by spread-filter tool (canonical#14519) testtime: add mockable timers for use in tests (canonical#14672) interface/screen_inhibit_control: Improve screen inhibit control for use on core (canonical#14134) tests: use images with 20G disk in openstack (canonical#14720) i/builtin: allow @ in custom-device filepaths (canonical#14651) tests: refactor test-snapd-desktop-layout-with-content tests: fix broken app definition tests: capitalize sentences in comments tests: wrap very long shell line tests: fix raciness in async startup and sync install ...
This task removes tests executions for uc16 but the support remains because we need to test core snap for security releases.
Other changes are included to move some tests from uc16 to uc18.
A new nightly job will be included to run uc16 tests and nested tests.