Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting, unit and integration tests pass for the frontend charm #16

Merged
merged 19 commits into from
Jun 6, 2023
+292 −70
Merged

Linting, unit and integration tests pass for the frontend charm #16

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ad74ae3
Linting, unit and integration tests pass for the frontend.
mz2 Jun 1, 2023
1f96110
Fixes a relation updating bug in the backend charm" -m"Fixed a bug, h…
mz2 Jun 1, 2023
231c98d
Ubuntu backed Dockerfile
mz2 Jun 2, 2023
f371de3
lxd from 5.12/beta for frontend integration tests
mz2 Jun 2, 2023
e20de5d
checkout@v2 -> v3
mz2 Jun 2, 2023
152561e
Backend charm import reordering to make ruff happy
mz2 Jun 2, 2023
21d9149
Clarified title to the linting and formatting report
mz2 Jun 2, 2023
2c4cf22
README update to cover the frontend test running
mz2 Jun 2, 2023
f02b021
Corrected glob pattern for looking up the built charm
mz2 Jun 2, 2023
e6356d2
79 char line length
mz2 Jun 2, 2023
b8a861f
Changes to 99 as the line length as requested.
mz2 Jun 2, 2023
3fde096
Leave out the port whenever it is the default for http or https
mz2 Jun 2, 2023
54ae218
Corrected test assertion.
mz2 Jun 2, 2023
a33df99
Apparently 5.12/edge instead
mz2 Jun 2, 2023
689b3c0
Oops, 5.12 -> 5.14
mz2 Jun 2, 2023
8223897
Oops, 5.13 after all
mz2 Jun 2, 2023
4a06b61
Move frontend integration tests to main branch and tagged commits.
mz2 Jun 2, 2023
4241df3
Formatting correction
mz2 Jun 2, 2023
bac0034
Merge branch 'main' into frontend-charm-tests
mz2 Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
checkout@v2 -> v3
@mz2
mz2 committed Jun 2, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mz2 Matias Piipari
GPG key ID: 697F1C7A4EE06A8D
Expired
Verified
Learn about vigilant mode
commit e20de5d95e64c6d8af94c09575c9a807d032386e
8 changes: 4 additions & 4 deletions .github/workflows/charm_analysis.yml
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ jobs:
name: Lint report
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install tox
run: pip install tox
- name: Run tests using tox
@@ -19,7 +19,7 @@ jobs:
name: Static analysis
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install tox
run: pip install tox
- name: Run tests using tox
@@ -29,7 +29,7 @@ jobs:
name: Unit tests
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install tox
run: pip install tox
- name: Run tests using tox
@@ -40,7 +40,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Setup LXD
uses: canonical/setup-lxd@main
with: