Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source link in docs should point to correct commit. #205

Closed
vqvu opened this issue Jan 23, 2015 · 3 comments · Fixed by #274
Closed

Source link in docs should point to correct commit. #205

vqvu opened this issue Jan 23, 2015 · 3 comments · Fixed by #274
Labels
bug documentation
Milestone
v2.5.0

Comments

@vqvu
Copy link
Collaborator

vqvu commented Jan 23, 2015

The source link for functions in the documentation should point to the tag for the release, and not to the master branch.
@vqvu
Copy link
Collaborator Author

vqvu commented Apr 16, 2015

Also, we'll want to change references to rawgithub.com to cdn.rawgit.com in light of #272. See #271 for the fix.

@vqvu vqvu mentioned this issue Apr 16, 2015
Closed
@vqvu vqvu added this to the v2.5.0 milestone Apr 17, 2015
@svozza svozza mentioned this issue Apr 17, 2015
Merged
@svozza
Copy link
Collaborator

svozza commented Apr 17, 2015

I actually thought that fix I merged resolved this but I didn't even see it was on that gh-branch. I've created a pull request with the necessary changes.

jeromew added a commit that referenced this issue May 4, 2015
@jeromew
Fix #205: Source link in docs should point to correct commit
e1d8220
@jeromew
Copy link
Collaborator

jeromew commented May 4, 2015

The {{tag}} replacement was not beeing replaced with the tag version number upon `grunt build'. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Use cdn.rawgithub and Link To Specific Version Rather Than Master svozza/highland
3 participants
@jeromew @vqvu @svozza