Use cdn.rawgithub and Link To Specific Version Rather Than Master #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix other links to use cdn fix stream doc info for sort functions fix javadocs
svozza
force-pushed
the
fix-raw-cdn-issue
branch
from
88766d0 to
3a6d708
Compare
|
Yeah, this is possible. We use handlebars, so we just need to add the proper value into the context. You can pull in vqvu@d40b335 (docs-gen branch) and run the |
|
For some reason I couldn't cherry pick that commit so I just copied out the changes manually as there weren't many of them. The pre-release task worked for me locally and all the links were correct. |
|
You should undo the package.json and bower.json changes. Those should only be updated once we release. |
|
Doh! That's what I get for being lazy and doing |
|
LGTM |
svozza
added a commit
that referenced
this pull request
Apr 18, 2015
Use cdn.rawgithub and Link To Specific Version Rather Than Master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
I don't really know how the doc generation works but is there a way that we can add the version of Highland dynamically? Something like:
Otherwise I can see us forgetting to update this file occasionally.