Add and test empty method
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`empty` creates a stream with no values.
|
Don't Fantasyland method names need to be prefixed now? E.g., https://github.com/fantasyland/fantasy-land#prefixed-method-names |
vqvu
reviewed
Oct 26, 2018
lib/index.js
Outdated
| */ | ||
|
|
||
| addToplevelMethod('empty', function () { | ||
| return _([]); |
There was a problem hiding this comment.
Use this([]) instead of _([]).
There's a new feature in 3.0 (not yet documented) called use that lets you extend the stream prototype. Using this will make sure that you construct the new stream using the correct prototype.
Note that of has the same bug.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emptycreates a stream with no values.This turns a Highland stream into a Monoid