Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fantasy-land canonical method names #658

Merged
merged 17 commits into from
Oct 31, 2018

Conversation

amsross
Copy link
Contributor

@amsross amsross commented Oct 25, 2018

This PR is to resolve #656

This currently includes mappings and tests for the following types:

package.json Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@vqvu
Copy link
Collaborator

vqvu commented Oct 27, 2018

Can you make the tests pass? I think you're missing fantasy-land/ap.

@amsross
Copy link
Contributor Author

amsross commented Oct 27, 2018

The tests for this aren't possible to pass because of the dependency on ap, which is provided by #643.

@vqvu
Copy link
Collaborator

vqvu commented Oct 28, 2018

Oh, right. I forgot. I thought ap was already implemented. I've merged #643.

@amsross
Copy link
Contributor Author

amsross commented Oct 28, 2018

I think the that's the last of it. I had to rework the ap - noValueOnError tests a bit because I think I was using the noValueOnErrorTest function incorrectly to get a false positive.

I also had to rework the _.of tests because I had only partially (and incorrectly) implemented them awaiting _([]).ap

I believe those are the only changes since your previous review.

@amsross
Copy link
Contributor Author

amsross commented Oct 28, 2018

Ok, one more thing: I just updated package-lock.json because it was mismatched with package.json (+ fantasy-land). If you have a preferred way of minimizing some of those changes, I can revert and update it that way.

@vqvu
Copy link
Collaborator

vqvu commented Oct 31, 2018

Looks good to me. The changes to package-lock.json are fine.

Thanks so much for all of your work on this.

@vqvu vqvu merged commit b8111f7 into caolan:master Oct 31, 2018
@amsross
Copy link
Contributor Author

amsross commented Oct 31, 2018

As always, thanks for the careful and thoughtful reviews!

@svozza
Copy link
Collaborator

svozza commented Oct 31, 2018

All this fantasyland work you've done has been great. Thanks!

@amsross amsross deleted the add-fantasy-land-method-names branch October 31, 2018 14:10
@amsross
Copy link
Contributor Author

amsross commented Oct 31, 2018

How does this all end up getting rolled up into a release?

@vqvu
Copy link
Collaborator

vqvu commented Nov 1, 2018

I need to manually run a grunt task. I'll do that after I add some advertisement about the Fantasy Land work (in #663).

@vqvu
Copy link
Collaborator

vqvu commented Nov 1, 2018

3.0.0-beta.7 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fantasy-land canonical type references?
3 participants