-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fantasy-land canonical method names #658
Conversation
Can you make the tests pass? I think you're missing |
The tests for this aren't possible to pass because of the dependency on |
Oh, right. I forgot. I thought |
I think the that's the last of it. I had to rework the I also had to rework the I believe those are the only changes since your previous review. |
Ok, one more thing: I just updated |
Looks good to me. The changes to Thanks so much for all of your work on this. |
As always, thanks for the careful and thoughtful reviews! |
All this fantasyland work you've done has been great. Thanks! |
How does this all end up getting rolled up into a release? |
I need to manually run a grunt task. I'll do that after I add some advertisement about the Fantasy Land work (in #663). |
3.0.0-beta.7 is released. |
This PR is to resolve #656
This currently includes mappings and tests for the following types:
fantasy-land/ap
=>_.ap
fantasy-land/of
=>_.of
fantasy-land/map
=>_.map
fantasy-land/chain
=>_.flatMap
fantasy-land/filter
=>_.filter
fantasy-land/alt
=>_.otherwise
fantasy-land/concat
=>_.concat
fantasy-land/empty
=>_.empty
fantasy-land/zero
=>_.empty