Code

Implement the Observable spec#673

Code

Merged

vqvu merged 19 commits intocaolan:mastercaolan/highland:masterfrom jaidetree:subscribe-with-nil-filejaidetree/highland:subscribe-with-nil-fileCopy head branch name to clipboardMar 8, 2019

+521-20

Commits

Commits on Feb 27, 2019

• Created subscribe method for RxJS\Observable compatibility

  jaidetree

  committed
  6e66ac3

  Copy full SHA for 6e66ac3

Commits on Feb 28, 2019

• Implemented subscribe according to observable spec

  Show description for 0831bdc
  jaidetree

  committed
  0831bdc

  Copy full SHA for 0831bdc

Commits on Mar 1, 2019

• Added Symbol.observable support

  jaidetree

  committed
  2a4f121

  Copy full SHA for 2a4f121

• Credit RxJS as source of observable symbol resolution

  jaidetree

  committed
  934daab

  Copy full SHA for 934daab

Commits on Mar 2, 2019

• Pull review requested changes for caolan#672

  Show description for 48fa72a
  jaidetree

  committed
  48fa72a

  Copy full SHA for 48fa72a

Commits on Mar 3, 2019

• Fixed subscribe method PR requested changes

  Show description for a1edb49
  jaidetree

  committed
  a1edb49

  Copy full SHA for a1edb49

• Fixed subscribe tests when subscribing to completed stream

  jaidetree

  committed
  01e7783

  Copy full SHA for 01e7783

• Tests for observableSubscription behavior

  jaidetree

  committed
  890aa05

  Copy full SHA for 890aa05

• Finished first draft of observableSubscription

  jaidetree

  committed
  f2dae55

  Copy full SHA for f2dae55

• Added more documentation to observableSubscription

  jaidetree

  committed
  7a053ae

  Copy full SHA for 7a053ae

• Update ObservableSubscription for PR requested changes:

  Show description for ffbb15a
  jaidetree

  committed
  ffbb15a

  Copy full SHA for ffbb15a

Commits on Mar 4, 2019

• Fixed subscribe PR changes in caolan#672

  Show description for fb7c149
  jaidetree

  committed
  fb7c149

  Copy full SHA for fb7c149

• Fixed lint error in subscribe method

  jaidetree

  committed
  1be35e9

  Copy full SHA for 1be35e9

• Fixed subscribe PR requested changes

  Show description for 5ca90ae
  jaidetree

  committed
  5ca90ae

  Copy full SHA for 5ca90ae

• Submit method PR requested changes

  Show description for a2a3b25
  jaidetree

  committed
  a2a3b25

  Copy full SHA for a2a3b25

• First cut of splitting up global and nil resolution and moving consume logic to observableSubscription

  jaidetree

  committed
  f2d9b0a

  Copy full SHA for f2d9b0a

• Fleshed out nil.js

  jaidetree

  committed
  d9c5cc4

  Copy full SHA for d9c5cc4

• Separated createObserver.js file

  jaidetree

  committed
  437418b

  Copy full SHA for 437418b

Commits on Mar 7, 2019

• Completed Round 1 of caolan#673 requested changes

  Show description for f14d5ef
  jaidetree

  committed
  f14d5ef

  Copy full SHA for f14d5ef