Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic validation for Capact manifests #398

Closed
3 tasks done
pkosiec opened this issue Jul 19, 2021 · 1 comment
Closed
3 tasks done

Implement basic validation for Capact manifests #398

pkosiec opened this issue Jul 19, 2021 · 1 comment
Assignees
Labels
area/cli Relates to CLI area/engine Relates to Engine area/hub Relates to Hub enhancement New feature or request
Milestone

Comments

@pkosiec
Copy link
Member

pkosiec commented Jul 19, 2021

Description

Capact CLI [3SP]

capact validate for creating new manifests

  1. Check if JSON schema in Types valid
    • Fix the JSON schemas if needed
  2. Additional validation against Public Hub (enabled with an additional flag): [2SP]
    • Interface input + output: check typeRef + revision exists in Hub
    • Implementation: additionalInput.typeInstances : check typeRef + revision exists in Hub
    • Implements: check path + revision exists in Hub
    • Requires: check all requirements (path + revision) exist in Hub
    • Imports: check all methods from InterfaceGroups exist in Hub
    • Implementation + Type: check path + revision for every Attribute in metadata if exists in Hub
    • Validate all manifests and collect all errors
    • Update development guide

hub-manifests CI [1SP]

Spawn local Capact installation with CLI and run CLI manifests validation against existing Hub
- Reuse what we have on capactio/capact
- Idea: Populator should populate manifests from PR - disable populator in cluster, run populator locally

Subtasks

Reason

Validation is essential for creating new Capact manifests to avoid mistakes.

@pkosiec
Copy link
Member Author

pkosiec commented Aug 9, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to CLI area/engine Relates to Engine area/hub Relates to Hub enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant