Implement concurrent manifest validation against Hub in CLI #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
/pkg/sdk/manifest
validation-related logic to/pkg/sdk/manifest/validation
Notes
This PR is based on branch with fixes from #436. Once #436 is merged, this PR will be rebased to latest
main
.EDIT: Done
Testing
Run Capact from
main
branch:Populate Hub manifests from
main
branch:kubectl -n capact-system port-forward svc/neo4j-neo4j 7687:7687 APP_JSONPUBLISHADDR=http://$(ipconfig getifaddr en0) go run cmd/populator/main.go register ocf-manifests ../hub-manifests
Log in to Capact CLI: https://capact.io/docs/cli/getting-started#first-use
Run the following command against cloned
hub-manifests
inmain
branch:-v / --verbose
flag--server-side
flagCheck out the fixed manifests from PR: Fix manifest lint errors detected by CLI hub-manifests#16
Run the populator:
kubectl -n capact-system port-forward svc/neo4j-neo4j 7687:7687 APP_JSONPUBLISHADDR=http://$(ipconfig getifaddr en0) go run cmd/populator/main.go register ocf-manifests ../hub-manifests
Follow the 3rd step again. Observe no errors in manifests.
Related issue(s)
#398