Fix manifest lint errors detected by CLI #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
added
bug
pkosiec
requested review from
lukaszo,
mszostok,
platten and
Trojan295
as code owners
This was referenced Aug 9, 2021
mszostok
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
How you fixed those schemas? I assume, that you fix that in automatic way. Can we have sth like that also embedded in our CLI?
For example, capact manifests lint --fix or capact manifest interfaces fmt or sth like that.
WDYT? IMO it will be really useful. I know that I will use it quite a lot :D
|
@mszostok I couldn't agree more that it would be great 😄 I fixed all errors manually, using online tool. We would need to figure out what we actually can fix automatically and search for Go libraries, which fix e.g. JSON errors (commas), etc. You can create a task for that, but I think we won't be able to implement that anytime soon 😞 |
pkosiec
changed the title
Trojan295
pushed a commit
to Trojan295/hub-manifests
that referenced
this pull request
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
capactio/capact#398