Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure in TestSendDisembargo/SendQueuedResultToCaller #426

Closed
lthibault opened this issue Jan 13, 2023 · 0 comments
Closed

Failure in TestSendDisembargo/SendQueuedResultToCaller #426

lthibault opened this issue Jan 13, 2023 · 0 comments
Labels
bug

Comments

@lthibault
Copy link
Collaborator 

--- FAIL: TestSendDisembargo (0.01s)
    --- FAIL: TestSendDisembargo/SendQueuedResultToCaller (0.01s)
Error:         level1_test.go:285: Received finish message; want disembargo
Error:         level0_test.go:2126: conn error: rpc: send release: send message: context canceled

Originally posted by @lthibault in #424 (comment)
@zenhack zenhack added the bug label Jan 14, 2023
@lthibault lthibault mentioned this issue Jan 14, 2023
Closed
This was referenced Jan 19, 2023
Merged
Merged
This was referenced Jan 28, 2023
Merged
Merged
Merged
Merged
zenhack added a commit to zenhack/go-capnp that referenced this issue Feb 4, 2023
@zenhack
Fix bug in TestSendDisembargo/SendQueuedResultToCaller
27aa4bd 
Sadly, I don't think this is capnproto#426, but I noticed it while hunting that
down: we set Which to receiverHosted but then set the SenderHosted
field. This patch fixes that.

I think we're getting lucky in the test such that it passes anyway
because we only ever put one export on the wire so the ID is always zero
anyway.
@zenhack zenhack mentioned this issue Feb 4, 2023
Merged
lthibault added a commit that referenced this issue Feb 6, 2023
@lthibault
Merge pull request #444 from zenhack/fix-426
54e4f09 
Fix #426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zenhack @lthibault