Fix bug in TestSendDisembargo/SendQueuedResultToCaller #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, I don't think this is capnproto#426, but I noticed it while hunting that down: we set Which to receiverHosted but then set the SenderHosted field. This patch fixes that. I think we're getting lucky in the test such that it passes anyway because we only ever put one export on the wire so the ID is always zero anyway.
|
Have I mentioned I wish Go had sum types? |
|
And indeed, this is not #426, since it triggered again. Re-running. |
It comes so damn close with interfaces/type-switching, too. |
lthibault
approved these changes
Feb 4, 2023
|
Quoting Louis Thibault (2023-02-04 14:04:30)
It comes so damn close with interfaces/type-switching, too.
...We probably *could* make this safer by changing out the `Which` field
used by pogs to be an interface that you type-switch on, with nil just
being treated as the default. Would have to think about some of the
details, though I think this also gets easier if we implement #63, since
we then could move away from reflection, which I'd like to do anyway...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, I don't think this is #426, but I noticed it while hunting that down: we set Which to receiverHosted but then set the SenderHosted field. This patch fixes that.
I think we're getting lucky in the test such that it passes anyway because we only ever put one export on the wire so the ID is always zero anyway.