Stub out places where we need to add logic for 3PH #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I plan on adding panic("TODO: 3PH") everywhere we need to add some 3PH
related logic; this shouldn't affect existing applications, since these
are all conditional on us actually having a non-nil network.
I went through the Haskell implementation to help enumerate these, having done something similar when I was writing that.
lthibault
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have no functional change, except for:
This patch just stubs out the places where logic will need to be modified to support 3PH; I think it will be helpful to have these enumerated up front. I took some pointers from the Haskell implementation on this, since I added similar markers as comments when I was writing that in the first place.