Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub out places where we need to add logic for 3PH #469

Merged
merged 4 commits into from
Feb 26, 2023
Merged

Stub out places where we need to add logic for 3PH #469

merged 4 commits into from
Feb 26, 2023

Commits on Feb 25, 2023

  1. Stubs for handling accept & provide 

    I plan on adding panic("TODO: 3PH") everywhere we need to add some 3PH
related logic; this shouldn't affect existing applications, since these
are all conditional on us actually having a non-nil network.
    @zenhack
    zenhack committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    ead6a66 View commit details
    Browse the repository at this point in the history

  2. Stub out more places relevant to 3PH

    @zenhack
    zenhack committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    1bec2ab View commit details
    Browse the repository at this point in the history

  3. Add a few more TODO: 3PH markers. 

    I went through the Haskell implementation to help enumerate these,
having done something similar when I was writing that.
    @zenhack
    zenhack committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    959be2b View commit details
    Browse the repository at this point in the history

  4. Clean up accept/provide stubs.

    @zenhack
    zenhack committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    fe493d7 View commit details
    Browse the repository at this point in the history