Add TriCore Architecture #1973

imbillow · 2023-03-10T22:14:54Z

Changes based on https://github.com/TriDis/capstone/tree/tricore, adaptations for new capstone versions and support for current versions of the TriCore instruction set.

The current tc1.6.2 version of instruction set disassembly is almost complete. Other versions actually overlap with tc1.6.2 for the most part, with only a small amount of extra content, which is still under construction.

Then it should be mentioned that basically all the .inc is generated using the modified llvm-tblgen from https://github.com/Rot127/llvm-capstone/tree/auto-sync-tblgen, except for TriCoreGenDisassemblerTables.inc, which modified a small part of DecodeInstruction and DecodeToMCInst

TODO:

aquynh · 2023-03-10T22:30:55Z

Very nice work! From which llvm is this, please?

imbillow · 2023-03-10T22:49:12Z

Very nice work! From which llvm is this, please?

Maybe https://github.com/TriDis/llvm-tricore

aquynh · 2023-03-10T23:05:37Z

Is that unmaintained repo?

…

On Sat, Mar 11, 2023, 05:49 billow ***@***.***> wrote: Very nice work! From which llvm is this, please? Maybe https://github.com/TriDis/llvm-tricore — Reply to this email directly, view it on GitHub <#1973 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNQNYBHORMKVOVWAY6C4KDW3OVXJANCNFSM6AAAAAAVXABL74> . You are receiving this because you commented.Message ID: ***@***.***>

imbillow · 2023-03-10T23:19:42Z

Yes, and I meant to use this as a starting point only. We could probably maintain TriCore's TableGen and TriCoreDisassembler code ourselves.

aquynh · 2023-03-10T23:25:32Z

Can we assume that this arch is no longer developed? (Unlike Arm, x86, etc)

…

On Sat, Mar 11, 2023, 06:19 billow ***@***.***> wrote: Yes, and I meant to use this as a starting point only. We could probably maintain TriCore's TableGen and TriCoreDisassembler code ourselves. — Reply to this email directly, view it on GitHub <#1973 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNQNYGVZ3B2YHQC2EC5N3DW3OZJRANCNFSM6AAAAAAVXABL74> . You are receiving this because you commented.Message ID: ***@***.***>

imbillow · 2023-03-10T23:52:18Z

I think it's just not as widely used.

imbillow · 2023-03-11T08:20:21Z

ping @XVilka

XVilka · 2023-03-11T08:36:59Z

@imbillow @imbillow this arch is indeed not widely used but quite common in the automotive and few other industries. This architecture is still being improved with ISA changes slightly from version to version, latest one being 1.6.2:

https://wiki.qemu.org/Documentation/Platforms/TriCore

The aforementioned LLVM fork isn't complete and abandoned, and Infineon didn't indicate that they plan to implement Tricore support in the mainline LLVM or even some open fork. Thus, I suggest we focus only on the capstone and maintain it separately from the LLVM things.

XVilka · 2023-03-11T08:39:47Z

@imbillow note, there are slight differences for some instructions between different ISA versions, we should add the way to specify the particular ISA in the API.

XVilka · 2023-03-13T02:07:51Z

@Rot127 could you please also take a look, in case it will interfere with the auto-sync work?

Rot127 · 2023-03-13T14:38:22Z

@XVilka Looks good to me.
Only the architectures which are generated with auto-sync will be adjusted to each other. Since you mentioned that Tricore will not be in the LLVM mainline (and is therefore not a candidate for auto-sync) there's no need to adjust it to the auto-sync design.

cs.c

kabeor · 2023-03-25T03:12:05Z

plz check CIFuzz.

Test MC/RISCV/insn-riscv64.s.cs
Test MC/TriCore/ADC_Background_Scan_1_KIT_TC275_LK.s.cs
fail CS_ARCH_TRICORE CS_MODE_TRICORE
Traceback (most recent call last):
  File "./test_corpus.py", line 134, in <module>
    test_file(fname.strip())
  File "./test_corpus.py", line 125, in test_file
    fout.write(unichr(mc_modes[(arch, mode)]))
KeyError: ('CS_ARCH_TRICORE', 'CS_MODE_TRICORE')
2023-03-25 03:08:35,059 - root - ERROR - Building fuzzers failed.
2023-03-25 03:08:35,060 - root - ERROR - Error building fuzzers for (commit: b01e5c9b2261bfad775d21b7c4b62fb5a59e229f, pr_ref: refs/pull/1973/merge).

Rot127 · 2023-03-25T11:24:47Z

Could you please check my messages in Rizins Mattermost? Depending what you say regarding the auto-sync compatibility, I'd like to review this as well.

cstool/cstool.c

docs/TricoreInstructions.ods

imbillow · 2023-03-27T19:49:04Z

There should be special handling for different versions of ISA that hasn't been done yet. Currently, only TC1.6.2 is being referenced. Also, the testing may not be comprehensive enough, and I feel that there are still quite a few bugs present.

XVilka · 2023-04-06T04:26:09Z

@imbillow could you please also maintain a very brief TODO/status in the PR description?

imbillow · 2023-04-06T09:15:47Z

@imbillow could you please also maintain a very brief TODO/status in the PR description?

done

imbillow · 2023-04-09T19:40:19Z

Now our disassembled mnemonic and op_str are pretty good, but inst_detail is not quite as good

XVilka · 2023-04-10T02:14:32Z

@kabeor could you please take a look at this to give the early feedback, since majority of the code was written, also to allow the CI jobs to run?

XVilka · 2023-04-10T15:43:28Z

@imbillow see also:

Traceback (most recent call last):
  File "./test_corpus.py", line 149, in <module>
    test_file(fname.strip())
  File "./test_corpus.py", line 64, in test_file
    "CS_MODE_TRICORE_110": CS_MODE_TRICORE_110,
NameError: global name 'CS_MODE_TRICORE_110' is not defined
2023-04-10 14:22:54,188 - root - ERROR - Building fuzzers failed.

imbillow · 2023-04-10T17:35:32Z

Because I'm not very familiar with Python 2, so I converted the test_corpus.py file to Python 3 syntax, resulting in the new test_corpus3.py. Their functionalities should be essentially the same.

However, the cifuzz GitHub action relies on google/oss-fuzz to complete the fuzz test, so it won't use test_corpus3.py. But I think it should still be useful, so I submitted it anyway.

XVilka · 2023-04-11T13:50:21Z

@kabeor what do you think about such script conversion?

XVilka

LGTM. @aquynh @kabeor all your feedback was addressed. Your call now.

include/capstone/tricore.h

kabeor · 2023-04-27T01:36:29Z

Then we can merge

bindings/python/capstone/tricore.py

bindings/python/capstone/tricore_const.py

suite/test_corpus3.py

Co-authored-by: Rot127 <45763064+Rot127@users.noreply.github.com>

imbillow · 2023-05-01T15:01:05Z

@kabeor Hi, the problem you mentioned has been fixed, please review again.

Rot127 · 2023-05-02T11:00:24Z

@kabeor @aquynh Is it ready to be merged?

kabeor · 2023-05-02T11:15:11Z

@imbillow @Rot127 It's really great, can you solve the conflict so I can merge?

XVilka · 2023-05-03T01:34:04Z

@kabeor looks like conflict was resolved 😁

kabeor · 2023-05-03T03:30:57Z

Thanks again for this great work! Merged.

XVilka · 2023-05-04T09:04:29Z

@aquynh @kabeor what do you think about tagging 5.0-rc3 with that (and release 5.0 once it's stable enough)? I wonder if it make sense to release 5.0 before auto-sync is merged, and focus 5.1 on auto-sync work?
cc @imbillow @Rot127

Maybe addressing these two first though: #2010 and #2009

aquynh · 2023-05-04T10:43:41Z

this is what i am planning to do.

anything else do you think should be merged before rc3 tag?

aquynh · 2023-05-04T10:46:16Z

@aquynh @kabeor what do you think about tagging 5.0-rc3 with that (and release 5.0 once it's stable enough)? I wonder if it make sense to release 5.0 before auto-sync is merged, and focus 5.1 on auto-sync work? cc @imbillow @Rot127

Maybe addressing these two first though: #2010 and #2009

yes, please make pull req for the above issues before rc3 tag.

my main concern now is that the Pypi package is still properly generated for all platforms.

Rot127 · 2023-05-04T14:30:19Z

I wonder if it make sense to release 5.0 before auto-sync is merged, and focus 5.1 on auto-sync work?

@aquynh Would agree with releasing v5.0 before auto-sync and v5.1 for updated ARM, PPC and whatever else is done at this point.

aquynh · 2023-05-04T14:36:36Z

I wonder if it make sense to release 5.0 before auto-sync is merged, and focus 5.1 on auto-sync work?

@aquynh Would agree with releasing v5.0 before auto-sync and v5.1 for updated ARM, PPC and whatever else is done at this point.

yes the auto-sync is a big change, so I want to release 5.0 before merging that.

peace-maker · 2023-05-30T16:54:35Z

bindings/python/capstone/__init__.py

@@ -708,6 +726,8 @@ def __gen_detail(self):
            (self.operands) = bpf.get_arch_info(self._raw.detail.contents.arch.bpf)
        elif arch == CS_ARCH_RISCV:
            (self.operands) = riscv.get_arch_info(self._raw.detail.contents.arch.riscv)
+        elif arch == CS_ARCH_TRICORE:
+            (self.operands) = riscv.get_arch_info(self._raw.detail.contents.arch.tricore)


Should this be tricore.get_arch_info instead of riscv.get_arch_info?

You are right

@peace-maker Could you please send a new PR to fix these errors?

imbillow force-pushed the tricore branch 2 times, most recently from e4c79bf to 40a81fe Compare March 24, 2023 12:17

imbillow marked this pull request as ready for review March 25, 2023 00:26

kabeor reviewed Mar 25, 2023

View reviewed changes

cs.c Outdated Show resolved Hide resolved

imbillow marked this pull request as draft March 26, 2023 01:33

XVilka suggested changes Mar 27, 2023

View reviewed changes

cstool/cstool.c Outdated Show resolved Hide resolved

docs/TricoreInstructions.ods Outdated Show resolved Hide resolved

kabeor added the enhancement label Apr 6, 2023

imbillow force-pushed the tricore branch from 175cec9 to 2320214 Compare April 7, 2023 19:28

imbillow marked this pull request as ready for review April 9, 2023 19:21

Fix tricore.h

4d693da

XVilka approved these changes Apr 26, 2023

View reviewed changes

Rot127 approved these changes Apr 26, 2023

View reviewed changes

Rot127 mentioned this pull request Apr 26, 2023

Evm support rizinorg/rizin#3368

Closed

5 tasks

kabeor requested changes Apr 27, 2023

View reviewed changes

include/capstone/tricore.h Outdated Show resolved Hide resolved

kabeor requested changes Apr 27, 2023

View reviewed changes

bindings/python/capstone/tricore.py Show resolved Hide resolved

bindings/python/capstone/tricore_const.py Outdated Show resolved Hide resolved

Merge branch 'next' into tricore

620f0d0

imbillow mentioned this pull request Apr 28, 2023

Fix Captialize Target name and indent Rot127/llvm-capstone#3

Merged

Rot127 reviewed Apr 30, 2023

View reviewed changes

suite/test_corpus3.py Outdated Show resolved Hide resolved

imbillow and others added 3 commits May 1, 2023 22:52

Upper all inc and fix

985b6fc

Upper tricore_const.py

588a3e1

Update suite/test_corpus3.py

a1c3b63

Co-authored-by: Rot127 <45763064+Rot127@users.noreply.github.com>

Merge branch 'next' into tricore

a658d37

kabeor approved these changes May 3, 2023

View reviewed changes

kabeor merged commit 98f1155 into capstone-engine:next May 3, 2023

Rot127 mentioned this pull request May 9, 2023

auto-sync progress tracker: Refactor and implement architectures #2015

Open

47 tasks

imbillow deleted the tricore branch May 10, 2023 12:39

peace-maker reviewed May 30, 2023

View reviewed changes

chenrui333 mentioned this pull request Jul 6, 2023

chore: rename tricore_feature to is_tricore_feature_enabled qemu/qemu#240

Closed

Add TriCore Architecture #1973

Add TriCore Architecture #1973

Conversation

imbillow commented Mar 10, 2023 • edited Loading

aquynh commented Mar 10, 2023 via email

imbillow commented Mar 10, 2023

aquynh commented Mar 10, 2023 via email

imbillow commented Mar 10, 2023

aquynh commented Mar 10, 2023 via email

imbillow commented Mar 10, 2023

imbillow commented Mar 11, 2023

XVilka commented Mar 11, 2023

XVilka commented Mar 11, 2023

XVilka commented Mar 13, 2023

Rot127 commented Mar 13, 2023

kabeor commented Mar 25, 2023

Rot127 commented Mar 25, 2023 • edited Loading

imbillow commented Mar 27, 2023

XVilka commented Apr 6, 2023

imbillow commented Apr 6, 2023

imbillow commented Apr 9, 2023

XVilka commented Apr 10, 2023

XVilka commented Apr 10, 2023

imbillow commented Apr 10, 2023

XVilka commented Apr 11, 2023

XVilka left a comment

Choose a reason for hiding this comment

kabeor commented Apr 27, 2023 • edited Loading

imbillow commented May 1, 2023

Rot127 commented May 2, 2023

kabeor commented May 2, 2023

XVilka commented May 3, 2023

kabeor commented May 3, 2023

XVilka commented May 4, 2023 • edited Loading

aquynh commented May 4, 2023

aquynh commented May 4, 2023

Rot127 commented May 4, 2023

aquynh commented May 4, 2023

peace-maker May 30, 2023

Choose a reason for hiding this comment

imbillow May 30, 2023

Choose a reason for hiding this comment

imbillow May 30, 2023

Choose a reason for hiding this comment

imbillow commented Mar 10, 2023 •

edited

Loading

Rot127 commented Mar 25, 2023 •

edited

Loading

kabeor commented Apr 27, 2023 •

edited

Loading

XVilka commented May 4, 2023 •

edited

Loading