Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(listitem): title tag added #3719

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

rkkp1023
Copy link

@rkkp1023 rkkp1023 commented Feb 15, 2023

Closes : #3646

Summary

Title tag is added in the list item

Change List (commits, features, bugs, etc)

Just added tag in list-item component

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@rkkp1023 rkkp1023 requested a review from a team as a code owner February 15, 2023 17:52
@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit e3e9d2b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/63f6156c64a85100081c9982
😎 Deploy Preview https://deploy-preview-3719--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -78,6 +78,7 @@ import { IconService } from 'carbon-components-angular';
[ngClass]="{ 'iot--list-item--content--values--main__large': item.size === 'lg' }"
>
<div
title="Item {{ item.value }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine you would want this to come from a translatable string.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , It's fine and I removed the hardcoded value Item .

@rkkp1023 rkkp1023 requested a review from davidicus February 22, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[List] HTML Title tag
5 participants