-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(listitem): title tag added #3719
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-addons-iot-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -78,6 +78,7 @@ import { IconService } from 'carbon-components-angular'; | |||
[ngClass]="{ 'iot--list-item--content--values--main__large': item.size === 'lg' }" | |||
> | |||
<div | |||
title="Item {{ item.value }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine you would want this to come from a translatable string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , It's fine and I removed the hardcoded value Item
.
Closes : #3646
Summary
Title tag is added in the list item
Change List (commits, features, bugs, etc)
Just added tag in list-item component
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.