Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(listitem): title tag added #3719

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix(listitem): title tag added #3719

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f21c6a3
fix(listitem): title tag added
ravi-kumar70 Feb 15, 2023
e3e9d2b
fix(listitem): removed hardcoded Item text
ravi-kumar70 Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/angular/src/list/list-item/ai-list-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ import { IconService } from 'carbon-components-angular';
[ngClass]="{ 'iot--list-item--content--values--main__large': item.size === 'lg' }"
>
<div
title="Item {{ item.value }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine you would want this to come from a translatable string.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , It's fine and I removed the hardcoded value Item .

class="iot--list-item--content--values--value"
[ngClass]="{
'iot--list-item--category': item.isCategory,
Expand Down