fix(react): stop passing selectionMode through as a prop (#5908)

Co-authored-by: Josh Black <josh@josh.black>
carbon-design-system · Apr 23, 2020 · 14868eb · 14868eb
1 parent 844bfcc
commit 14868eb
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/packages/react/src/components/ContentSwitcher/ContentSwitcher-test.js b/packages/react/src/components/ContentSwitcher/ContentSwitcher-test.js
@@ -40,6 +40,10 @@ describe('ContentSwitcher', () => {
  it('should apply extra classes passed to it', () => {
  expect(wrapper.hasClass('extra-class')).toEqual(true);
  });
+
+ it('should not have a selectionMode prop', () => {
+ expect('selectionMode' in wrapper.props()).toEqual(false);
+ });
  });
 
  describe('Allow initial state to draw from props', () => {

diff --git a/packages/react/src/components/ContentSwitcher/ContentSwitcher.js b/packages/react/src/components/ContentSwitcher/ContentSwitcher.js
@@ -112,6 +112,7 @@ export default class ContentSwitcher extends React.Component {
  children,
  className,
  selectedIndex, // eslint-disable-line no-unused-vars
+ selectionMode, // eslint-disable-line no-unused-vars
  ...other
  } = this.props;
 

diff --git a/packages/react/src/components/Tabs/Tabs-test.js b/packages/react/src/components/Tabs/Tabs-test.js
@@ -74,6 +74,12 @@ describe('Tabs', () => {
  .hasClass(`${prefix}--tabs--container`)
  ).toBe(true);
  });
+
+ it('has no selectionMode prop', () => {
+ expect(
+ 'selectionMode' in wrapper.find(`.${prefix}--tabs`).props()
+ ).toBe(false);
+ });
  });
 
  describe('Trigger (<div>)', () => {

diff --git a/packages/react/src/components/Tabs/Tabs.js b/packages/react/src/components/Tabs/Tabs.js
@@ -227,6 +227,7 @@ export default class Tabs extends React.Component {
  role,
  type,
  onSelectionChange,
+ selectionMode, // eslint-disable-line no-unused-vars
  tabContentClassName,
  ...other
  } = this.props;