Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): stop passing selectionMode through as a prop #5908

Merged
merged 4 commits into from
Apr 22, 2020

Conversation

s100
Copy link
Contributor

@s100 s100 commented Apr 22, 2020

Closes #5903.

In <ContentSwitcher> and <Tabs>, the selectionMode is no longer passed as a prop to the inner <div>.

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Unit tests have been added to demonstrate this issue. Reviewers can also view these components in Storybook and see that the errors in question have gone away. However, you might consider altering your unit testing so that all errors of this kind cause a failure automatically.

@s100 s100 requested a review from a team as a code owner April 22, 2020 13:16
@ghost ghost requested review from aledavila and tw15egan April 22, 2020 13:17
@s100
Copy link
Contributor Author

s100 commented Apr 22, 2020

Incidentally, while following the contribution instructions, I found that yarn build consistently fails like so:

@carbon/themes:  INFO  Creating sassdoc markdown for pattern: 'scss/**/*.scss', ignoring: ''
@carbon/themes: » [WARNING] Item `carbon--theme` is an alias of `carbon--theme--white` but this item doesn't exist.
@carbon/themes:  SUCCESS  Done! �
@carbon/pictograms-react:  INFO  Writing to destination
@carbon/icons:  INFO  Building JavaScript modules...
@carbon/icons: [Error: EMFILE: too many open files, open 'C:\Users\s100\Documents\WebstormProjects\carbon\packages\icons\lib\t
ext--new-line\16.js'] {
@carbon/icons:   errno: -4066,
@carbon/icons:   code: 'EMFILE',
@carbon/icons:   syscall: 'open',
@carbon/icons:   path: 'C:\\Users\\s100\\Documents\\WebstormProjects\\carbon\\packages\\icons\\lib\\text--new-line\\16.js'
@carbon/icons: }
@carbon/icons: error Command failed with exit code 1.
@carbon/icons: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run build exited 1 in '@carbon/icons'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any clue what causes this?

@netlify
Copy link

netlify bot commented Apr 22, 2020

Deploy preview for carbon-elements ready!

Built with commit cd2a7e4

https://deploy-preview-5908--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 22, 2020

Deploy preview for carbon-components-react ready!

Built with commit cd2a7e4

https://deploy-preview-5908--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I'm able to replicate the EMFILE build failure only on Windows, and I think we can open that as a separate issue

@joshblack joshblack merged commit 93adb34 into carbon-design-system:master Apr 22, 2020
@s100 s100 deleted the no-selection-modes branch April 23, 2020 09:35
joshblack added a commit to joshblack/carbon that referenced this pull request Apr 23, 2020
joshblack added a commit to joshblack/carbon that referenced this pull request Apr 23, 2020
joshblack added a commit that referenced this pull request Apr 23, 2020
Co-authored-by: Josh Black <josh@josh.black>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: React does not recognize the selectionMode prop on a DOM element.
3 participants