Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Notification Action Button style issue from style lint update #6507

Closed
1 of 2 tasks
renmaddox opened this issue Jul 21, 2020 · 0 comments · Fixed by #6511
Closed
1 of 2 tasks

Inline Notification Action Button style issue from style lint update #6507

renmaddox opened this issue Jul 21, 2020 · 0 comments · Fixed by #6511
Assignees
@emyarod
Labels
component: notification role: dev 🤖 type: bug 🐛

Comments

@renmaddox
Copy link

[Title]: Use of secondary and primary buttons within inline notification styled incorrectly

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Secondary and Primary buttons within ToastNotification are no longer styled correctly.

Problem introduced by #6370 in version 10.16.0.

It appears that the scoping change on line 283 of _inline_notificaiton.scss may not have been intentional.

Before the change:
before

After the change:
after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: notification role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(inline-notification): restore selector to original scope emyarod/carbon
3 participants
@emyarod @laurenmrice @renmaddox