fix(inline-notification): restore selector to original scope #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
approved these changes
Jul 21, 2020
|
Deploy preview for carbon-elements ready! Built with commit f3efdde |
|
Deploy preview for carbon-elements ready! Built with commit b8eacb9 |
|
Deploy preview for carbon-components-react ready! Built with commit f3efdde https://deploy-preview-6511--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit b8eacb9 https://deploy-preview-6511--carbon-components-react.netlify.app |
rjhenriquez
approved these changes
Jul 22, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6507
This PR restores a style selector for notification action buttons. Initially this was changed in #6370 due to the a stylelint warning but the resulting selector did not match the previous, so it was a style regression for some notification action button consumers
Testing / Reviewing
Confirm the notification action button styles target the same selectors inside all notification variants