Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): fix style lint errors #6370

Merged
merged 9 commits into from
Jul 10, 2020

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Jul 1, 2020

Fixes style linting errors now that #6170 has been merged.

Testing / Reviewing

Ensure form components still render correctly

@netlify
Copy link

netlify bot commented Jul 1, 2020

Deploy preview for carbon-elements ready!

Built with commit e253e92

https://deploy-preview-6370--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 1, 2020

Deploy preview for carbon-components-react ready!

Built with commit e253e92

https://deploy-preview-6370--carbon-components-react.netlify.app

@tw15egan tw15egan force-pushed the style-lint branch 3 times, most recently from 87ab11c to d42280e Compare July 7, 2020 21:44
@tw15egan tw15egan marked this pull request as ready for review July 8, 2020 00:05
@tw15egan tw15egan requested a review from a team as a code owner July 8, 2020 00:05
@ghost ghost requested review from emyarod and joshblack July 8, 2020 00:05
@tw15egan tw15egan changed the title chore(lint): start fixing style lint errors chore(lint): fixstyle lint errors Jul 8, 2020
@tw15egan tw15egan changed the title chore(lint): fixstyle lint errors chore(lint): fix style lint errors Jul 8, 2020
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great to me! Only question is around if it fixes all violations, if it does holy hell you're amazing, TJ haha. If not, do we want to remove the lint:styles from CI check?

@tw15egan
Copy link
Member Author

tw15egan commented Jul 8, 2020

@joshblack It should pass the CI check 👍

@joshblack
Copy link
Contributor

Seems like there might be a stylelint violation @tw15egan maybe from a recent merge:

image

@tw15egan
Copy link
Member Author

@joshblack 🧙 fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants