feat(stylelint): add stylelint-config-carbon #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jendowns if you have any recommendations! |
|
Deploy preview for carbon-elements ready! Built with commit bfa6345 |
|
Deploy preview for carbon-components-react ready! Built with commit bfa6345 https://deploy-preview-6170--carbon-components-react.netlify.app |
tay1orjones
reviewed
Jun 1, 2020
…feat/add-stylelint-config-carbon
ghost
requested review from
tw15egan
approved these changes
Jul 1, 2020
|
@emyarod @andreancardona let me know if you have any questions about this PR! |
emyarod
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a new package called
stylelint-config-carbonthat has our stylelint configuration for the monorepo and for other projects in the carbon ecosystem.It currently does not add listing styles to our CI check. Instead, we'll chip away at this over time and have
lint-stagedcatch changes to be fixed on a per-file basis. When we get full coverage, we'll add stylelint to our CI check.This PR adds in the package (moving from
stylelint-config-elements), updates some dependencies for stylelint, adds in some new rules, and also fixes some stylelint issues in Sass files around the project.Changelog
New
stylelint-config-carbonChanged
Removed
stylelint-config-elements