Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(condensed-grid): moved vertical spacing to col #4960

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

photodow
Copy link
Contributor

@photodow photodow commented Jan 7, 2020

Continuation of #4577

@photodow photodow requested a review from a team as a code owner January 7, 2020 15:55
@ghost ghost requested review from aledavila and joshblack January 7, 2020 15:55
@github-actions github-actions bot added the package: grid @carbon/grid label Jan 7, 2020
@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for carbon-components-react ready!

Built with commit 7145b82

https://deploy-preview-4960--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for the-carbon-components ready!

Built with commit 7145b82

https://deploy-preview-4960--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for carbon-elements ready!

Built with commit 7145b82

https://deploy-preview-4960--carbon-elements.netlify.com

@joshblack
Copy link
Contributor

@jendowns curious what you think about this if you have a sec!

Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after talking to josh, this seems like we're just changing how we set the space for the but the effect should be the same. Looks ok to me.

@joshblack joshblack merged commit b02d19e into carbon-design-system:master Jan 10, 2020
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 13, 2020
* fix(condensed-grid): moved vertical spacing to col

* chore(grid): updating snapshot

Co-authored-by: Alessandra Davila <adavila91@gmail.com>
Co-authored-by: Josh Black <josh@josh.black>
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 14, 2020
* fix(condensed-grid): moved vertical spacing to col

* chore(grid): updating snapshot

Co-authored-by: Alessandra Davila <adavila91@gmail.com>
Co-authored-by: Josh Black <josh@josh.black>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants