test(ComboBox): add vrt #9497
test(ComboBox): add vrt #9497
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 2d1558a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6127744af78cbb000a9f79fc 😎 Browse the preview: https://deploy-preview-9497--carbon-react-next.netlify.app |
|
@tay1orjones I tried to add a click event on this like Accordion tests, and check to see that the list items are showing, but I'm running into issues with it. I get an error when I try to check for |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 2d1558a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6127744a9cd2b90008b5ebc4 😎 Browse the preview: https://deploy-preview-9497--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 2d1558a 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6127744a03302e00080995a7 😎 Browse the preview: https://deploy-preview-9497--carbon-components-react.netlify.app |
|
Ok, I think I fixed the error I was running into. Should be ready for review. |
| const items = [ | ||
| { | ||
| id: 'option-0', | ||
| text: | ||
| 'An example option that is really long to show what should be done to handle long text', | ||
| }, |
There was a problem hiding this comment.
Forgot to mention something I found useful for Dropdown was the generateItems and generateGenericItem helpers from ../ListBox/test-helpers. It helps cut down the boilerplate a bit
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Closes #9268
Adds percy snapshots for ComboBox
Testing / Reviewing