Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ComboBox): add vrt #9497

Merged
merged 4 commits into from
Aug 26, 2021
Merged

test(ComboBox): add vrt #9497

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f9ccab
test(ComboBox): add vrt
jnm2377 Aug 18, 2021
ebe8643
fix: open snapshot for combobox
jnm2377 Aug 18, 2021
4a08469
fix: remove unnecessary html
jnm2377 Aug 18, 2021
2d1558a
Merge branch 'main' into vrt-combobox
kodiakhq[bot] Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 157 additions & 0 deletions packages/react/src/components/ComboBox/ComboBox-test.e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,157 @@
/**
* Copyright IBM Corp. 2016, 2018
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

import 'carbon-components/scss/components/combo-box/_combo-box.scss';
import 'carbon-components/scss/components/list-box/_list-box.scss';
import 'carbon-components/scss/components/text-input/_text-input.scss';

import React from 'react';
import { mount } from '@cypress/react';
import ComboBox from './ComboBox';

describe('ComboBox', () => {
beforeEach(() => {
const items = [
{
id: 'option-0',
text:
'An example option that is really long to show what should be done to handle long text',
},
Comment on lines +18 to +23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention something I found useful for Dropdown was the generateItems and generateGenericItem helpers from ../ListBox/test-helpers. It helps cut down the boilerplate a bit

{
id: 'option-1',
text: 'Option 1',
},
{
id: 'option-2',
text: 'Option 2',
},
{
id: 'option-3',
text: 'Option 3',
},
{
id: 'option-4',
text: 'Option 4',
},
{
id: 'option-5',
text: 'Option 5',
},
];

mount(
<>
<div style={{ marginBottom: '2rem' }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Default combobox"
helperText="Optional combobox helper text"
/>
</div>
<div style={{ marginBottom: '2rem' }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Small combobox"
helperText="Combobox helper text"
size="sm"
/>
</div>
<div style={{ marginBottom: '2rem' }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Large combobox"
helperText="Combobox helper text"
size="lg"
/>
</div>
<div style={{ marginBottom: '2rem' }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Disabled combobox"
helperText="Combobox helper text"
disabled
/>
</div>
<div style={{ marginBottom: '2rem' }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Light combobox"
helperText="Combobox helper text"
light
/>
</div>
<div style={{ marginBottom: '2rem' }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Combobox with warning state"
helperText="Combobox helper text"
warn
warnText="Warning state message here"
/>
</div>
<div style={{ marginBottom: 8 }}>
<ComboBox
onChange={() => {}}
id="carbon-combobox"
items={items}
itemToString={(item) => (item ? item.text : '')}
placeholder="Filter..."
titleText="Combobox with invalid state"
helperText="Combobox with invalid state"
invalid
invalidText="Invalid text message here"
/>
</div>
</>
);
});

it('should render', () => {
cy.findByText(/Optional/).should('be.visible');

// snapshots should always be taken _after_ an assertion that
// a element/component should be visible. This is to ensure
// the DOM has settled and the element has fully loaded.
cy.percySnapshot();
});

it('should open on click and display list items', () => {
cy.findAllByRole('button').first().click();
cy.findAllByText(/Option 1/)
.first()
.should('be.visible');

// snapshots should always be taken _after_ an assertion that
// a element/component should be visible. This is to ensure
// the DOM has settled and the element has fully loaded.
cy.percySnapshot();
});
});