Skip to content

Commit

Permalink
Remove supurfluous/confusing {} around a temporary (#4183)
Browse files Browse the repository at this point in the history
This was failing to build for me locally with some arbitrary Clang HEAD
host compiler:
```
migrate_cpp/rewriter.cpp:225:3: error: call to member function 'SetReplacement' is ambiguous
  225 |   SetReplacement(expr, {OutputSegment(std::move(text))});
      |   ^~~~~~~~~~~~~~
./migrate_cpp/rewriter.h:141:8: note: candidate function [with T = clang::IntegerLiteral]
  141 |   auto SetReplacement(const T* node, std::vector<OutputSegment> output_segments)
      |        ^
./migrate_cpp/rewriter.h:150:8: note: candidate function [with T = clang::IntegerLiteral]
  150 |   auto SetReplacement(const T* node, OutputSegment segment) -> void {
      |        ^
```
No idea if that's a bug in clang HEAD, but it seemed like removing the
{} simplified the code anyway - so here's that.
  • Loading branch information
dwblaikie authored and brymer-meneses committed Aug 15, 2024
1 parent 5700d1d commit 11e3c77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion migrate_cpp/rewriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ auto RewriteBuilder::VisitIntegerLiteral(clang::IntegerLiteral* expr) -> bool {
c = '_';
}
}
SetReplacement(expr, {OutputSegment(std::move(text))});
SetReplacement(expr, OutputSegment(std::move(text)));
return true;
}

Expand Down

0 comments on commit 11e3c77

Please sign in to comment.