Skip to content

Commit

Permalink
Refactor single-unit checking out of check.cpp (#4649)
Browse files Browse the repository at this point in the history
This is primarily moving code around, to try to create a logical split
of the code in check.cpp, makingthe API boundaries clearer.

There's one small, deliberate logic change around false returns from
`HandleParseNode`, where before there was a `CARBON_CHECK` instantiated
by the `#define` (per `NodeKind`), and now it's outside the `#define`
(done mainly because the message didn't keep up with the `Handle##Name`
-> `HandleParseNode` rename).
  • Loading branch information
jonmeow authored Dec 10, 2024
1 parent 92201ce commit 87b3671
Show file tree
Hide file tree
Showing 7 changed files with 612 additions and 536 deletions.
2 changes: 2 additions & 0 deletions toolchain/check/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ cc_library(
name = "check",
srcs = [
"check.cpp",
"check_unit.cpp",
"check_unit.h",
"deferred_definition_worklist.cpp",
"deferred_definition_worklist.h",
"handle.h",
Expand Down
Loading

0 comments on commit 87b3671

Please sign in to comment.