Refactor single-unit checking out of check.cpp #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
check-unit-refactor
branch
from
b8d89be to
62546a0
Compare
jonmeow
force-pushed
the
check-unit-refactor
branch
from
62546a0 to
2511f24
Compare
zygoloid
approved these changes
Dec 10, 2024
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Dec 16, 2024
This is primarily moving code around, to try to create a logical split of the code in check.cpp, makingthe API boundaries clearer. There's one small, deliberate logic change around false returns from `HandleParseNode`, where before there was a `CARBON_CHECK` instantiated by the `#define` (per `NodeKind`), and now it's outside the `#define` (done mainly because the message didn't keep up with the `Handle##Name` -> `HandleParseNode` rename).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily moving code around, to try to create a logical split of the code in check.cpp, makingthe API boundaries clearer.
There's one small, deliberate logic change around false returns from
HandleParseNode, where before there was aCARBON_CHECKinstantiated by the#define(perNodeKind), and now it's outside the#define(done mainly because the message didn't keep up with theHandle##Name->HandleParseNoderename).