Update to bazel 8.0.0 #4729
Open
Update to bazel 8.0.0 #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
bazel-version
branch
2 times, most recently
from
9604aae to
acc59ff
Compare
jonmeow
force-pushed
the
bazel-version
branch
from
acc59ff to
7e5ad5b
Compare
github-actions
bot
added
documentation
chandlerc
reviewed
Dec 20, 2024
MODULE.bazel
Outdated
Comment on lines
68
to
72
| # protobuf and tcmalloc rely on incompatible rules_fuzzing versions. Force the | ||
| # protobuf version, even though it's just an indirect dependency of something. | ||
| # | ||
| # TODO: This is probably okay because of how we use tcmalloc, but it's | ||
| # definitely undesirable and should be removed when possible. |
There was a problem hiding this comment.
Can we remove this now that we don't have the protobuf issue?
There was a problem hiding this comment.
Removed -- I thought I'd still been seeing a conflict but I guess not.
There was a problem hiding this comment.
Nice!
If one comes up, not a big deal, but good to document whatever is left causing it.
chandlerc
approved these changes
Dec 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 21, 2024
As part of migrating to the latest bazel configurations in #4729, I'm running into proto toolchain issues. For example: "Error: <target @@protobuf+//:cc_toolchain> (rule 'proto_lang_toolchain') doesn't contain declared provider 'ProtoLangToolchainInfo'" Although we may eventually want more use of proto, right now the only use is for the explorer fuzzer. The explorer codebase is essentially frozen, so continuing to run it isn't gaining us much (in fact, we've already disabled autofuzzing for it). So, rather than trying to fix the proto setup, this change: 1. Deletes `explorer/fuzzing` 2. Removes proto portions of `testing/fuzzing`, which were only in-use by the explorer 3. Removes some ancillary proto support, which would otherwise break from the bazel changes and would be difficult to validate as "still working" This change is partly isolated in order to make it easier to revive bits of (3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to bazel 8.0.0, also updating bazel mod deps and tools to make that function. The release is a couple weeks old, and we haven't updated in a while, and it's a major release. Note it includes some incompatible flag flips that this is trying to update with respect to. I'll try generally enabling incompatible support separately.
The most visible bazel behavior change here will be the change from
~to+in repo path names. (If you're curious, bazelbuild/bazel#23127 indicates this fixes a Windows performance issue)Note that this is building on top of both the action env update in #4728 (which got me started down this path) and the proto removal in #4731 (which would add significant work to this update). Only the commit starting at "Work towards bazel 8.0.0" is specifically part of this PR.