Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explorer's proto fuzzer and proto dependencies #4731

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Dec 20, 2024

As part of migrating to the latest bazel configurations in #4729, I'm running into proto toolchain issues. For example:
"Error: <target @@protobuf+//:cc_toolchain> (rule 'proto_lang_toolchain') doesn't contain declared provider 'ProtoLangToolchainInfo'"

Although we may eventually want more use of proto, right now the only use is for the explorer fuzzer. The explorer codebase is essentially frozen, so continuing to run it isn't gaining us much (in fact, we've already disabled autofuzzing for it).

So, rather than trying to fix the proto setup, this change:

  1. Deletes explorer/fuzzing
  2. Removes proto portions of testing/fuzzing, which were only in-use by the explorer
  3. Removes some ancillary proto support, which would otherwise break from the bazel changes and would be difficult to validate as "still working"

This change is partly isolated in order to make it easier to revive bits of (3).

@github-actions github-actions bot requested a review from zygoloid December 20, 2024 21:12
@github-actions github-actions bot added explorer Action items related to Carbon explorer code infrastructure toolchain labels Dec 20, 2024
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. I briefly wondered if it'd be worth converting the existing fuzz corpus to carbon source files and adding it to the toolchain fuzz corpus, but it looks like we already did that :)

@jonmeow jonmeow enabled auto-merge December 20, 2024 22:27
@jonmeow jonmeow added this pull request to the merge queue Dec 20, 2024
Merged via the queue into carbon-language:trunk with commit 266fd6a Dec 21, 2024
8 checks passed
@jonmeow jonmeow deleted the disable-explorer-fuzzer branch December 21, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Action items related to Carbon explorer code infrastructure toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants