-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename sslStrict argument as sslInsecure #60
Rename sslStrict argument as sslInsecure #60
Conversation
This matches exactly what I was thinking from our discussion in the issue. Please set the version number back so a new major increment doesn’t happen. The publish of the task takes care of the versioning automatically. |
Hi, |
You make a good point and I think for that reason, it's not going to make sense to make this change. There isn't a good reason to break this and not make it backward compatible, even between major versions. |
Oh, come on, don't be shy! That's what major version changes are for. |
@afeblot I'm on board with doing this. Just need to make sure that we include a section in the readme so people understand it's a breaking change. Otherwise, there will be a lot of upset and more importantly confused users. Would you mind to add something? |
Forgot the release is setup to auto-create release notes. This should help with this, but still need something in the readme. |
Thanks @carlowahlstedt . |
Finally getting back to this. It all looks good. Thanks for the thought and work here. It will be helpful with yaml going forward as you mentioned. |
Rename
sslStrict
tosslInscure
in order to make the parameter more consistent with its actual behavior, to help with #58.