Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sslStrict argument as sslInsecure #60

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Rename sslStrict argument as sslInsecure #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a3fabf
Rename sslStrict argument as sslInsecure
May 21, 2019
50647c2
Describe the breaking change in the readme.
afeblot Jun 28, 2019
04aa031
Fix markdown style consistency on the previous change
afeblot Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions NewmanPostman/newmantask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ function GetToolRunner(collectionToRun: string) {
newman.argIf(typeof sslClientCert != 'undefined' && tl.filePathSupplied('sslClientCert'), ['--ssl-client-cert', sslClientCert]);
let sslClientKey = tl.getPathInput('sslClientKey', false, true);
newman.argIf(typeof sslClientKey != 'undefined' && tl.filePathSupplied('sslClientKey'), ['--ssl-client-key', sslClientKey]);
let sslStrict = tl.getBoolInput('sslStrict');
newman.argIf(sslStrict, ['--insecure']);
let sslInsecure = tl.getBoolInput('sslInsecure');
newman.argIf(sslInsecure, ['--insecure']);

let unicodeDisabled = tl.getBoolInput('unicodeDisabled');
newman.argIf(unicodeDisabled, ['--disable-unicode']);
Expand Down Expand Up @@ -181,4 +181,4 @@ async function run() {
}
}

run();
run();
8 changes: 4 additions & 4 deletions NewmanPostman/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
],
"author": "Carlo Wahlstedt",
"version": {
"Major": 3,
"Major": 4,
"Minor": 0,
"Patch": 23
"Patch": 0
},
"demands": [],
"groups": [
Expand Down Expand Up @@ -241,7 +241,7 @@
"groupName": "ssl"
},
{
"name": "sslStrict",
"name": "sslInsecure",
"type": "boolean",
"label": "Disable Strict SSL",
"helpMarkDown": "Disables strict ssl",
Expand Down Expand Up @@ -410,4 +410,4 @@
"target": "newmantask.js"
}
}
}
}
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ Following command line options are **not supported**:
- `--ssl-client-passphrase`
- None of the [CLI option](https://github.com/postmanlabs/newman#cli-reporter-options)

### Breaking change(s) ###

#### Version 4.x ####

* The `sslStrict` parameter is renamed as `sslInsecure` in order to better match with the actual behavior of the parameter: setting it to `true` will use newman `--insecure` option to disable the strict SSL verification.

### Known issue(s) ###

- None
Expand Down