Rework 'lookup types' handling into LookupChoiceFilter #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
changed the title
LookupChoiceFilter class
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
==========================================
+ Coverage 97.95% 97.98% +0.03%
==========================================
Files 15 15
Lines 1122 1140 +18
==========================================
+ Hits 1099 1117 +18
Misses 23 23
Continue to review full report at Codecov.
|
|
Yep - this does fix #843, in so far as the build no longer fails to even run 😄 |
rpkilby
force-pushed
the
rework-lookup-types
branch
2 times, most recently
from
b1c359a
to
41c5437
Compare
added 9 commits
May 21, 2018 01:44
These tests were used for comparing a filter's behavior when it was provided a list of lookup expressions. This comparison is no longer relevant, since the 'lookup choices' behavior is being moved to a separate filter class.
rpkilby
force-pushed
the
rework-lookup-types
branch
from
41c5437
to
c88ff57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "lookup types" handling for
Filter.lookup_expr, where alistorNonevalue would trigger the use ofLookupTypeField. This has been replaced with a dedicatedLookupChoiceFilter.I decided to replace the feature outright and raise an assertion with the relevant removal message, instead of attempting to go through a deprecation path. While it should be possible, it didn't seem worth the effort to try support/deprecate the old functionality, especially given the clean break 2.0 provides.
Should also fix #843 (at least the reliance on the defunct
QUERY_TERMS).Changes:
LookupChoiceFilterlistandNonevalue handling forlookup_expr. Using this form will fail an assertion check.LOOKUP_TYPESmodule variable fromdjango_filters.filters.LookupTypeWidgettoLookupChoiceWidget.LookupTypeFieldtoLookupChoiceField.Lookup.lookup_typetoLookup.lookup_expr.Lookupto only accept non-empty values. If aLookupis missing a value, aNoneshould be provided instead.