Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework 'lookup types' handling into LookupChoiceFilter #851

Merged
merged 9 commits into from
Jul 13, 2018
Merged

Rework 'lookup types' handling into LookupChoiceFilter #851

merged 9 commits into from
Jul 13, 2018

Commits on May 21, 2018

  1. Revert carltongibson#347, Lookup arguments must be non-empty

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    1da920d View commit details
    Browse the repository at this point in the history

  2. Rename Lookup.lookup_type => Lookup.lookup_expr

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    10a1765 View commit details
    Browse the repository at this point in the history

  3. Rename LookupTypeWidget => LookupChoiceWidget

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    c2f7be9 View commit details
    Browse the repository at this point in the history

  4. Rename LookupTypeField => LookupChoiceField

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    cb8d405 View commit details
    Browse the repository at this point in the history

  5. Remove 'lookup choices' behavior from Filter

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    1cf26be View commit details
    Browse the repository at this point in the history

  6. Remove obsolete NumberFilter tests 

    These tests were used for comparing a filter's behavior when it was
provided a list of lookup expressions. This comparison is no longer
relevant, since the 'lookup choices' behavior is being moved to a
separate filter class.
    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    2966db1 View commit details
    Browse the repository at this point in the history

  7. Replace list form of 'lookup_expr' with filter

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    64f39ce View commit details
    Browse the repository at this point in the history

  8. Add LookupChoiceFilter docs and migration note

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    2016e21 View commit details
    Browse the repository at this point in the history

  9. Make lookup required when value is provided

    Ryan P Kilby committed May 21, 2018
    Configuration menu
    Copy the full SHA
    c88ff57 View commit details
    Browse the repository at this point in the history