Define "standard" downloads and provide a script to update #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html
Outdated
| --> | ||
| <!-- for swcarpentry/sql-novice-survey --> | ||
| <li><a href="http://files.software-carpentry.org/survey.db"><code>survey.db</code></a></li> | ||
| <li><a href="http://files.software-carpentry.org/survey.sql"><code>survey.sql</code></a></li> |
There was a problem hiding this comment.
These can (and should) use https: links.
There was a problem hiding this comment.
On Wed, Mar 23, 2016 at 08:37:54PM -0700, Elliott Sales de Andrade wrote:
This can (and should) use https: links.
That didn't work when I wrote the commit (see the commit message for
6b9f36c and swcarpentry/DEPRECATED-site#509), but it was fixed in on 2016-01-11
1. I've updated this PR (and rebased to resolve trivial conflicts
with #303) in 4fb0eb1→7f67d1e.
wking
force-pushed
the
list-downloads
branch
2 times, most recently
from
d9528df to
7f67d1e
Compare
So we can collect a list of everything learners will need for the workshop [1]. [1]: carpentries#276
Which landed in swcarpentry/shell-novice#141.
These are HTTPS versions of the URLs suggested in the lesson docs since swcarpentry/sql-novice-survey@ff0f411f (Making lesson conform to template, 2015-02-12). I prefer HTTPS links for security, and while files.software-carpentry.org has had an invalid certificate in the past [1], it works now (2016-03-23). As a fallback, you could use [2,3], but they seem too different from the lesson docs for me to prefer them here. [1]: swcarpentry/DEPRECATED-site#509 [2]: https://github.com/swcarpentry/files/raw/master/survey.db [3]: https://github.com/swcarpentry/files/raw/master/survey.sql
Which landed in swcarpentry/r-novice-inflammation#144. I'm keeping the download order in line with the syllabus order.
It's easier if lessons declare these themselves, and we just list the lessons we're using. This script fetches lesson-defined download lists and updates the Downloads section appropriately. I'd rather have used an HTML parser to make the substitution, because line.startswith(...) is brittle. Unfortunately, index.html is part YAML, part HTML, and part Jekyll, so there's no out-of-the-box parser. The lessons.json config format is compatible with my recommended dependency format [1]. [1]: wking/swc-setup-installation-test#9
|
@wking Sorry for the delay to look on it. The pull request has some conflicts now. Do you want to resolve or should I do it? |
|
On Sat, Feb 04, 2017 at 05:04:34AM -0800, Raniere Silva wrote:
The pull request has some conflicts now.
I'm happy to resolve these, but we should probably decide on
wking/swc-setup-installation-test#9 first. If we are unsure or
against wking/swc-setup-installation-test#9, we should drop the final
commit from this PR.
|
fmichonneau
pushed a commit
that referenced
this pull request
Jun 20, 2018
Rename CoC file to align with GitHub's Community Profile expectation
fmichonneau
added
type:enhancement
|
This was probably a good idea but too much has changed since this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit message. The from the last commit is based on
the changes in wking/swc-setup-installation-test#9, and the lesson
JSON files in both PRs are compatible.
If/when lesson maintainers start providing the download-declaring JSON
files, we can provide an example lessons.json file in this repository.
Fixes #276.
Previous discussion in