Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client methods should return Status instead of bool #27

Open
gaschler opened this issue Jul 26, 2018 · 0 comments
Open

Client methods should return Status instead of bool #27

gaschler opened this issue Jul 26, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@gaschler
Copy link
Contributor

An often seen pattern is to CHECK(client.Write(...)) or if(client.Write(...)).
In case of a connection issue, no details are given whether the connection dropped or authentication failed.
A better way would be to return grpc::Status for Client::Write and related methods.
@gaschler gaschler added the enhancement New feature or request label Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaschler