Refactor image related code. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirVer
commented
Nov 16, 2017
SirVer
commented
- Take immutable parameter as const ref instead of pointer.
- make kCairoFormat a global constant, since it is defined in many places in cartographer and cartographer_ros, but we rely on it actually always being the same value.
|
Followup in cartographer_ros will be send once this is in. |
cschuet
approved these changes
Nov 16, 2017
|
@wally-the-cartographer merge |
|
Merge requested by authorized user SirVer. Merge queue now has a length of 1. |
- Take immutable parameter as const ref instead of pointer. - make kCairoFormat a global constant, since it is defined in many places in cartographer and cartographer_ros, but we rely on it actually always being the same value.
SirVer
force-pushed
the
00_refactor_submap_painter
branch
from
ee2dd62 to
f4c4940
Compare
wally-the-cartographer
pushed a commit
to cartographer-project/cartographer_ros
that referenced
this pull request
Nov 16, 2017
ojura
pushed a commit
to larics/cartographer_combined
that referenced
this pull request
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.