Split up instance contributors into 3 single-purpose contributors #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from `ProxyInstanceContributor`, and change proxy type generators to use the new contributor for `IProxyTargetAccessor`. Remove everything that has become redundant.
stakx
force-pushed
the
dp/refactor/instance-contributors
branch
from
6e03540
to
dbc13a6
Compare
from `ProxyInstanceContributor`. Because it does not contribute a type, it is not added to `GetTypeImplementerMapping`'s list of contributors, but invoked directly in `GenerateType`.
as its sole remaining function is to implement `ISerializable`.
stakx
force-pushed
the
dp/refactor/instance-contributors
branch
from
dbc13a6
to
12f6964
Compare
stakx
commented
Jan 5, 2021
Comment on lines
+53
to
+64
| // we can only change the target of the interface proxy | ||
| if (targetReference is FieldReference targetField) | ||
| { | ||
| dynProxySetTarget.CodeBuilder.AddStatement( | ||
| new AssignStatement(targetField, | ||
| new ConvertExpression(targetField.Fieldbuilder.FieldType, dynProxySetTarget.Arguments[0].ToExpression()))); | ||
| } | ||
| else | ||
| { | ||
| dynProxySetTarget.CodeBuilder.AddStatement( | ||
| new ThrowStatement(typeof(InvalidOperationException), "Cannot change the target of the class proxy.")); | ||
| } |
There was a problem hiding this comment.
Both the code comment and the exception message are somewhat misleading, since there are interface proxies that also don't support changing the target. While even interface proxies without a target have a __target field, setting it has no effect whatsoever.
This is the original implementation from ProxyInstanceContributor and I opted not to change it for now, but perhaps in the future, we want to formally disallow changing the target of interface proxies without a target...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProxyInstanceContributorand its subtypes currently have three responsibilities:ISerializableIProxyTargetAccessorThis PR takes that type apart into three single-purpose contributors
SerializableContributor,ProxyTargetAccessorContributor, andNonInheritableAttributesContributor, where each one is responsible for the aspect it is named after.