Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up instance contributors into 3 single-purpose contributors #553

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Split up instance contributors into 3 single-purpose contributors #553

merged 3 commits into from
Jan 5, 2021

Commits on Jan 5, 2021

  1. Extract ProxyTargetAccessorContributor 

    from `ProxyInstanceContributor`, and change proxy type generators to use
the new contributor for `IProxyTargetAccessor`. Remove everything that
has become redundant.
    @stakx
    stakx committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    972b968 View commit details
    Browse the repository at this point in the history

  2. Extract NonInheritableAttributesContributor 

    from `ProxyInstanceContributor`. Because it does not contribute a type,
it is not added to `GetTypeImplementerMapping`'s list of contributors,
but invoked directly in `GenerateType`.
    @stakx
    stakx committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    05baeb1 View commit details
    Browse the repository at this point in the history

  3. ProxyInstanceContributor -> SerializableContributor 

    as its sole remaining function is to implement `ISerializable`.
    @stakx
    stakx committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    12f6964 View commit details
    Browse the repository at this point in the history