Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port): Add horse breeding #4330

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

ekaratzas
Copy link
Contributor

@ekaratzas ekaratzas commented Mar 10, 2024

Purpose of change

Add the ability for horses to reproduce and add monster type for baby horse (foal).

Original PR: CleverRaven/Cataclysm-DDA#55907

Describe the solution

Add monster type for foal and fields for horse to reproduce.

I did end up removing fields from foal because they don't seem to exist in our fork: biosignature and petfood.

Describe alternatives you've considered

Testing

Spawn horse. Make it reproduce via debug menu. See foal. Try it again with tamed horse. Result: many horses

foal

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 10, 2024
@scarf005 scarf005 changed the title feature(port): Add horse breeding feat(port): Add horse breeding Mar 10, 2024
@scarf005
Copy link
Member

- feature(port): Add horse breeding
+ feat(port): Add horse breeding

please check guideline for details

@LordZanos
Copy link
Contributor

petfood is what DDA uses to determine what tames it. We still have that based on flags, so foal should have CATTLEFODDER to match horses.

@ekaratzas
Copy link
Contributor Author

@LordZanos good point i m on it

Co-authored-by: LyleSY <26608431+LyleSY@users.noreply.github.com>
@RobbieNeko
Copy link
Contributor

Yup, caddlefodder is what the adult horses use too if one looks at it

@ekaratzas
Copy link
Contributor Author

Just added CATTLEFODDER flag to foals as well.

@scarf005 scarf005 requested a review from chaosvolt March 10, 2024 02:25
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honse

@scarf005 scarf005 merged commit 32f75ac into cataclysmbnteam:main Mar 10, 2024
10 checks passed
@ekaratzas ekaratzas deleted the add-horse-baby branch March 10, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants