Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add horse breeding #55907

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Add horse breeding #55907

merged 2 commits into from
Apr 5, 2022

Conversation

AtomicFox556
Copy link
Contributor

Summary

Content "Add horse breeding"

Purpose of change

Let horses reproduce just like other tamed animals, in order to make more horses.

Describe the solution

Add a foal monster that grows into an adult horse over time, and reproduction data for horses.

Describe alternatives you've considered

None.

Testing

Load the game with these changes, made sure that no errors happen.

Additional context

None.

@github-actions github-actions bot added Json astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 6, 2022
@NetSysFire NetSysFire added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Mar 6, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 7, 2022
@BrettDong BrettDong removed the Json label Mar 12, 2022
LyleSY
LyleSY requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly great, I'd just suggest making it so foals don't breed until maturity

data/json/monsters/mammal.json Outdated Show resolved Hide resolved
@LyleSY
Add the flag
a12494a 
Co-Authored-By: LyleSY <26608431+LyleSY@users.noreply.github.com>
@AtomicFox556
Copy link
Contributor Author

Done.

@kevingranade kevingranade merged commit e155f46 into CleverRaven:master Apr 5, 2022
@ekaratzas ekaratzas mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse approved these changes

@LyleSY LyleSY LyleSY approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AtomicFox556 @LyleSY @Maleclypse @kevingranade @BrettDong @NetSysFire