fix: specify emcumbrance for acidchitin, plated leather, etc armor directly instead of using broken inheritance #5645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
I was starting to work on something unrelated when I was reminded that #3861 is still a problem, screwing up acidchitin and plated leather items. Since I don't know how to fix it codewise I'm putting in a workaround.
Describe the solution
Converted the encumbrance definitions of acidchitin armor, plated leather armor, and fingerless glove variants to be explicitly set instead of relying on broken
proportional
andrelative
adjustments. Same thing I already had to do with superalloy armor. Even western boots and carbon fiber ballistic shields for that matter used it.Describe alternatives you've considered
Tormenting Scarf into looking at the code to fix it.
Testing
Additional context
This has been broken for over a year aaaa