Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify emcumbrance for acidchitin, plated leather, etc armor directly instead of using broken inheritance #5645

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

I was starting to work on something unrelated when I was reminded that #3861 is still a problem, screwing up acidchitin and plated leather items. Since I don't know how to fix it codewise I'm putting in a workaround.

Describe the solution

Converted the encumbrance definitions of acidchitin armor, plated leather armor, and fingerless glove variants to be explicitly set instead of relying on broken proportional and relative adjustments. Same thing I already had to do with superalloy armor. Even western boots and carbon fiber ballistic shields for that matter used it.

Describe alternatives you've considered

Tormenting Scarf into looking at the code to fix it.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Checked the items they inherit from and did basic math to confirm the encumbrance values are what they're supposed to be.
  3. Load-tested in compiled test build, confirmed acidchitin armor now actually has 15 encumbrance instead of 10.

image

Additional context

This has been broken for over a year aaaa

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 2, 2024
@chaosvolt chaosvolt changed the title fix: specify emcumbrance directly instead of using broken inheritance fix: specify emcumbrance for acidchitin, plated leather, etc armor directly instead of using broken inheritance Nov 2, 2024
@chaosvolt chaosvolt merged commit 51a76fa into cataclysmbnteam:main Nov 2, 2024
9 checks passed
@chaosvolt chaosvolt deleted the encumbrance-armorfix branch November 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants