Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): reimplement bone armor using heavy bones, additional post-apoc monster hunter profession, update chitin armor recipes for consistency #5646

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Nov 2, 2024

Checklist

Required

Optional

Purpose of change

De-obsoleting bone armor has been on my todo list for a while, and #5466 gave us a way to balance it a bit better by requiring more high-end bones to use for it. Decided not to just do a 1:1 reimplementation of the originals since that'd be too similar to leather armor sets (plus chitin, acidchitin, and scute armor all function the exact same way) in favor of mixing things up a bit.

Describe the solution

JSON changes:

  1. Reduced bash resistance of heavy bone from 4 to 3, reduced its cut resistance from 6 to 5.
  2. Added bone cuirass, helmet, vambraces, and greaves. All derive from a fitting counterpart armor and have 12/20/16 armor and 12 encumbrance (non-varsize, making it in between leather/chitin armor and acidchitin). Coverage values match what they inherit from. The helm and vambraces additionally use the same IDs as the old obsoleted bone armor items, meaning...
  3. Removed bone armor helmet and arm guards from obsoletion folder, leaving a comment in the JSON for what was left there to explain how they items have been reworked.
  4. Added recipes for the new bone armor items. Main component is of course heavy bones, also uses a bit of fabric backing as well as decent amount of cordage, set to the same skill levels as comparable pieces of chitin armor.
  5. Following up on feat(content): add a new post-apoc profession for starting with scaleskin/tooth gear #5644, added a companion profession to the monster hunter, a monster slayer that favors bone armor and more of a melee focus. Skills again focused on what'd be needed to craft the weapons and armor they start with.
  6. Likewise added the new profession to relevant scenarios that monster hunter was added in.
  7. Added UDP external tileset sprites for bone cuirass (worn, item sprite isn't a full suit to begin with) and greaves. Helm and arm guards still have their old sprites and those look fine to me.
  8. Misc: Standardized chitin and acidchitin recipes a bit to make tool use and booklearns consistent, fixed it haphazardly varying whether it will require sewing or not, and removed use of cordage from the recipes since it's already flavored as being sewn onto leather backing.
  9. Misc: Also bumped up material requirement of chitin/acidchitin armor guards since it stood out as notably much lower than the other pieces.

Documentation changes:

  1. Updated external tileset documentation.

Describe alternatives you've considered

Bringing back bone armor as it originally was implemented. I feel that'd be fairly bland and plain compared to making them stronger but less of a full-body protective suit compared to most of the monster armorsets, especially since this means the player can opt to wear parts of these over lighter armor on the normal layer.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Checked armor values to confirm that all pieces of bone armor match the table below.
  4. Spawned in items and confirmed sprites look as expected.
Screenshot:

Showing the item sprites and how it looks on the profession:
image

Profession info:
image

Armor Type Bash Armor Cut Armor Ballistic Armor Coverage Encumbrance Armor Rating
Leather Body Armor 8 8 8 90% 10 (fitted) 2.16
Chitinous Armor 12 14 10 95% 10 3.42
Biosilicified Chitin Armor 15 15 18 95% 15 3.04
Scaleskin Armor 15 15 15 90% 10 (fitted) 4.05
Bone Curiass 12 20 16 80% 12 3.2

Note: Acidchitin encumbrance value assumes the fix in #5645 is merged.

Armor Rating determined by summing up all three physical protection values, multiplying against coverage percent, then dividing by encumbrance (fitted encumbrance if VARSIZE). Final Armor Rating will vary a bit for bone armor since coverage isn't identical across all pieces.

Additional context

Relevant images of existing bone/horn/ivory armor

Lames made of horn, from a Sarmatian burial mound:
Filippovka_1,_Horn_armour_from_mound_29

Another example of lamellar armor made from horn according to google translate, unknown:
800px-___________________________

A classic example of a Myceanean boar's tusk helmet:
800px-Boars's_tusk_helmet_NAMA6568_Athens_Greece1

Another boar's tusk helmet:
Eberzahnhelm_Heraklion

Was first removed by this PR, Removing bone armor recipes. by @kevingranade: CleverRaven/Cataclysm-DDA#28064

Searched through DDA and so far looks like they haven't re-implemented it themselves, only addition I spotted was making the bone seer's wolf skull helmet craftable.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 2, 2024
@github-actions github-actions bot added the docs PRs releated to docs page label Nov 2, 2024
Copy link
Contributor

autofix-ci bot commented Nov 2, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@github-actions github-actions bot added the mods PR changes related to mods. label Nov 2, 2024
@chaosvolt chaosvolt changed the title feat(content): reimplement bone armor using heavy bones, update chitin armor recipes for consistency feat(content): reimplement bone armor using heavy bones, additional post-apoc monster hunter profession, update chitin armor recipes for consistency Nov 2, 2024
@RoyalFox2140 RoyalFox2140 self-requested a review November 2, 2024 16:07
@RoyalFox2140 RoyalFox2140 merged commit bea1a3b into cataclysmbnteam:main Nov 2, 2024
9 checks passed
@chaosvolt chaosvolt deleted the bone-armor-goes-nyoom branch November 2, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants