feat(content): reimplement bone armor using heavy bones, additional post-apoc monster hunter profession, update chitin armor recipes for consistency #5646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
De-obsoleting bone armor has been on my todo list for a while, and #5466 gave us a way to balance it a bit better by requiring more high-end bones to use for it. Decided not to just do a 1:1 reimplementation of the originals since that'd be too similar to leather armor sets (plus chitin, acidchitin, and scute armor all function the exact same way) in favor of mixing things up a bit.
Describe the solution
JSON changes:
Documentation changes:
Describe alternatives you've considered
Bringing back bone armor as it originally was implemented. I feel that'd be fairly bland and plain compared to making them stronger but less of a full-body protective suit compared to most of the monster armorsets, especially since this means the player can opt to wear parts of these over lighter armor on the normal layer.
Testing
Screenshot:
Showing the item sprites and how it looks on the profession:

Profession info:

Note: Acidchitin encumbrance value assumes the fix in #5645 is merged.
Armor Rating determined by summing up all three physical protection values, multiplying against coverage percent, then dividing by encumbrance (fitted encumbrance if
VARSIZE
). Final Armor Rating will vary a bit for bone armor since coverage isn't identical across all pieces.Additional context
Relevant images of existing bone/horn/ivory armor
Lames made of horn, from a Sarmatian burial mound:

Another example of lamellar armor made from horn according to google translate, unknown:

A classic example of a Myceanean boar's tusk helmet:

Another boar's tusk helmet:

Was first removed by this PR,
Removing bone armor recipes.
by @kevingranade: CleverRaven/Cataclysm-DDA#28064Searched through DDA and so far looks like they haven't re-implemented it themselves, only addition I spotted was making the bone seer's wolf skull helmet craftable.