Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Brick wall sprites #5664

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

thedyze
Copy link
Contributor

@thedyze thedyze commented Nov 4, 2024

Checklist

Required

Optional

  • I have documented the changes in the appropriate location in the doc/ folder.

Purpose of change

The current brick wall sprites are a mixed bag, having quite a flat, dull look. The red bricks are using an intense Christmas red
color, while the adobe brick uses a very pale yellow. For some reason the bricks themselves do not tile either, but rather uses a
sort of self contained look.

Describe the solution

This change aims improve the look of t_brick_wall and t_adobe_brick_wall multi tile sprites.
The new sprites seamlessly tile, includes some highlights and brick color differences to give them a bit more natural look.
This change also omits the bg property from said tiles, as I could not find a use for it. When deconstructed, a new tile is created in place. Please correct me if I'm wrong here.

brick1_2

brick2

Describe alternatives you've considered

Including an update for the "t_adobe_brick_wall_halfway", but decided against it. The reasoning for this is part that the halfway built red brick walls is a multi tile sprite which was not in need of updating while the adobe halfway is a single tile, which uses a transparent background, requiring then to include an override of the bg tile bg_dirt. Which I didn't intend to update.
Lastly, the current adobe halfway tile still work pretty good with the updated sprites, hence my decision to omit it from this change.

@github-actions github-actions bot added docs PRs releated to docs page JSON related to game datas in JSON format. labels Nov 4, 2024
@scarf005 scarf005 changed the title feat: Brick wall sprites updated feat: newer Brick wall sprites Nov 4, 2024
@scarf005 scarf005 changed the title feat: newer Brick wall sprites feat: new Brick wall sprites Nov 4, 2024
@RoyalFox2140 RoyalFox2140 merged commit 019cb0d into cataclysmbnteam:main Nov 4, 2024
9 checks passed
@thedyze thedyze deleted the brickWallSprites branch November 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants